Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Serialization tests for SQLClient types now that they no longer live in the dotnet/runtime repo #38949

Closed
joperezr opened this issue Jul 8, 2020 · 2 comments · Fixed by #42016
Closed

Remove Serialization tests for SQLClient types now that they no longer live in the dotnet/runtime repo #38949

joperezr opened this issue Jul 8, 2020 · 2 comments · Fixed by #42016
Labels
area-System.Runtime good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Milestone
Future

Comments

@joperezr
Copy link
Member

joperezr commented Jul 8, 2020

referencing @stephentoub's comment here #38948 (comment)

Now that SqlClient is no longer part of dotnet/runtime repo we should remove the serialization tests for those types. The comment on the PR above pretty much sumps up which section needs to be removed from the serialization test data.
@joperezr joperezr added area-System.Runtime good first issue Issue should be easy to implement, good for first-time contributors test-enhancement Improvements of test source code help wanted [up-for-grabs] Good issue for external contributors labels Jul 8, 2020
@joperezr joperezr added this to the Future milestone Jul 8, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jul 8, 2020
@joperezr joperezr removed the untriaged New issue has not been triaged by the area owner label Jul 8, 2020
@joperezr joperezr mentioned this issue Jul 8, 2020
Merged
@Wraith2
Copy link
Contributor

Wraith2 commented Jul 9, 2020

Some things can be removed like OperationAbortedException for example was moved out of System.Data into SqlClient and so the testing belongs in the M.D.SqlClient repo. Other things like SqlTruncateException are in System.Data.Common which remains in this repo and likely can't be moved for similar reasons to the SqlInt32 types, because DataAdapters use them. So anything that's in SqlClient assembly can go but anything in Common must still be tested in runtime.

@yujinnee
Copy link
Contributor

Let me do this.

@yujinnee yujinnee mentioned this issue Aug 28, 2020
Closed
@yujinnee yujinnee mentioned this issue Sep 9, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Runtime good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Removed Serialization tests for SQLClient types
4 participants
@Wraith2 @joperezr @Dotnet-GitSync-Bot @yujinnee