Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of System.IO.Compression OOB - .NET Standard 2.0 should forward to Desktop Framework #20074

Closed
karelz opened this issue Feb 1, 2017 · 8 comments · Fixed by dotnet/corefx#16045
Closed

Get rid of System.IO.Compression OOB - .NET Standard 2.0 should forward to Desktop Framework #20074

karelz opened this issue Feb 1, 2017 · 8 comments · Fixed by dotnet/corefx#16045
Labels
area-System.IO.Compression enhancement Product code improvement that does NOT require public API changes/additions
Milestone
2.0.0

Comments

@karelz
Copy link
Member

karelz commented Feb 1, 2017

The cost of shipping OOB for Desktop is very high and we have burned ourselves (System.Net.Http). Let's make sure we do not accidentally run into the same problems here as well.

cc: @ianhays @weshaggard
@karelz karelz changed the title Get rid of System.IO.Compression OOB - .NET Standard 2.0 should forward to Desktop on Desktop Get rid of System.IO.Compression OOB - .NET Standard 2.0 should forward to Desktop Framework Feb 1, 2017
@ianhays
Copy link
Contributor

ianhays commented Feb 1, 2017

cc: @ericstj

@mellinoe
Copy link
Contributor

mellinoe commented Feb 2, 2017

Presumably this was done to introduce new functionality or fix bugs, etc. Are we going to regress any of that?

@karelz
Copy link
Member Author

karelz commented Feb 2, 2017

@weshaggard mentioned we "just" fixed bugs. And yes, we are going to regress that, consciously.

@ianhays
Copy link
Contributor

ianhays commented Feb 2, 2017

We'll also be removing support for zips using deflate64 that was added in dotnet/corefx#11264.

@karelz
Copy link
Member Author

karelz commented Feb 2, 2017

Did it add any new APIs? Or "just" extend behavior of existing ones?

@ianhays
Copy link
Contributor

ianhays commented Feb 2, 2017

It extended the functionality of existing APIs.

@karelz
Copy link
Member Author

karelz commented Feb 2, 2017 •
edited
Loading

Thanks for confirmation. Despite that, I still believe we should rather make the change in .NET Standard 2.0.

@ianhays
Copy link
Contributor

ianhays commented Feb 2, 2017

I agree.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@karelz karelz mentioned this issue Jan 31, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.IO.Compression enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Remove NetFX Compression build
4 participants
@ianhays @karelz @mellinoe @msftgits