Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI support for testing APX #110672

Open
BruceForstall opened this issue Dec 12, 2024 · 4 comments
Open

Add CI support for testing APX #110672

BruceForstall opened this issue Dec 12, 2024 · 4 comments
Labels
apx Related to the Intel Advanced Performance Extensions (APX) area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@BruceForstall
Copy link
Member

Add testing support in the CI system for testing APX.

There are three basic phases:

  1. Before we have any APX hardware in the CI, what testing can we do? Assertion checking of the new EGPR/REX2/EVEX/If-Convert code paths using an altjit with those features enabled and a SPMI replay would be useful for assertion checking.
  2. When there are a few APX machines in CI, we can add limited, targeted executable testing.
  3. Eventually, if a large number or all CI test machines are APX enabled, we can run the full set of testing (including stress) with APX, but then we will also need to disable APX to ensure that scenario still works. Perf testing will also need to include APX.

There exists a runtime-coreclr jitstress-isas-avx512 pipeline (https://dev.azure.com/dnceng-public/public/_build?definitionId=235). Given all our CI machines are AVX-512 capable, do we still need this pipeline? Can this pipeline form a template to create a runtime-coreclr jitstress-isas-apx pipeline?

@BruceForstall BruceForstall added apx Related to the Intel Advanced Performance Extensions (APX) area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Dec 12, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Dec 12, 2024
@BruceForstall BruceForstall added this to the 10.0.0 milestone Dec 12, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Dec 12, 2024
@MichalPetryka
Copy link
Contributor

MichalPetryka commented Dec 13, 2024

  1. Before we have any APX hardware in the CI, what testing can we do?

Could there be a test pipeline running with Intel® Software Development Emulator (Intel® SDE) that has all ISAs emulated to be supported and runs the tests there?

@BruceForstall
Copy link
Member Author

Could there be a test pipeline running with Intel® Software Development Emulator (Intel® SDE) that has all ISAs emulated to be supported and runs the tests there?

It might be possible, but it is preferable to avoid this due to cost (development cost, runtime cost) and the almost inevitable oddities of the emulator. We would prefer to just wait until hardware is available.

@kunalspathak
Copy link
Member

Just to make sure we get coverage on JitStressRegs mentioned in #112239 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apx Related to the Intel Advanced Performance Extensions (APX) area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

No branches or pull requests

3 participants