Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is System.Text.Json 8.0.4 version is backward compatible with 8.0.3 version #107451

Closed
kogoel opened this issue Sep 6, 2024 · 3 comments
Closed
Labels
area-System.Text.Json question Answer questions and provide assistance, not an issue with source code or documentation.

Comments

@kogoel
Copy link

kogoel commented Sep 6, 2024

Steps:

  1. Created a nuget package using .netstandard 2.1 named XYZ_version_1.nupkg which is internally using System.Text.Json(8.0.3)
  2. It is serializing a object and copying the same into xyz.txt file.
  3. Due to vulnerability in System.Text.Json(8.0.3), we have to upgrade to System.Text.Json(8.0.4) in our XYZ_version_1.nupkg so created a new version XYZ_version_2.nupkg
  4. But the file which was already created using XYZ_version_1.nupkg is not correctly de-serialized and not getting the original object.

Please suggest whether the 8.0.4 version is backward compatible with 8.0.3

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Sep 6, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@huoyaoyuan
Copy link
Member

Patch versions only include bug and security fixes and are always backward compatible. System.Text.Json 8.0.4 only includes a security guard for IAsyncEnumerable deserialization and no other behavior has changed.

@teo-tsirpanis teo-tsirpanis added the question Answer questions and provide assistance, not an issue with source code or documentation. label Sep 6, 2024
@eiriktsarpalis
Copy link
Member

It's absolutely the case that 8.0.4 only includes a security patch specifically addressing buffering issues in the DeserializeAsyncEnumerable methods. It should have no impact on how objects serialize or deserialize from JSON.

That being said, if you have a minimal repro showcasing that this is not the case we would be happy to take a look at that.

@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Sep 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json question Answer questions and provide assistance, not an issue with source code or documentation.
Projects
None yet
Development

No branches or pull requests

4 participants