From 70a07d4bc9db92a0581dac5aed7ed9fb009d779f Mon Sep 17 00:00:00 2001 From: OwnageIsMagic Date: Wed, 6 Dec 2023 20:50:43 +0300 Subject: [PATCH] do not use default message if null passed for SystemException, ApplicationException, IOException --- .../src/System/ApplicationException.cs | 4 ++-- .../System.Private.CoreLib/src/System/IO/IOException.cs | 6 +++--- .../System.Private.CoreLib/src/System/SystemException.cs | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/libraries/System.Private.CoreLib/src/System/ApplicationException.cs b/src/libraries/System.Private.CoreLib/src/System/ApplicationException.cs index b8c9431cc4166b..40752739be271b 100644 --- a/src/libraries/System.Private.CoreLib/src/System/ApplicationException.cs +++ b/src/libraries/System.Private.CoreLib/src/System/ApplicationException.cs @@ -33,13 +33,13 @@ public ApplicationException() // and its ExceptionInfo reference set to null. // public ApplicationException(string? message) - : base(message ?? SR.Arg_ApplicationException) + : base(message) { HResult = HResults.COR_E_APPLICATION; } public ApplicationException(string? message, Exception? innerException) - : base(message ?? SR.Arg_ApplicationException, innerException) + : base(message, innerException) { HResult = HResults.COR_E_APPLICATION; } diff --git a/src/libraries/System.Private.CoreLib/src/System/IO/IOException.cs b/src/libraries/System.Private.CoreLib/src/System/IO/IOException.cs index b922d6b2006267..07dadbe6c206ec 100644 --- a/src/libraries/System.Private.CoreLib/src/System/IO/IOException.cs +++ b/src/libraries/System.Private.CoreLib/src/System/IO/IOException.cs @@ -18,19 +18,19 @@ public IOException() } public IOException(string? message) - : base(message ?? SR.Arg_IOException) + : base(message) { HResult = HResults.COR_E_IO; } public IOException(string? message, int hresult) - : base(message ?? SR.Arg_IOException) + : base(message) { HResult = hresult; } public IOException(string? message, Exception? innerException) - : base(message ?? SR.Arg_IOException, innerException) + : base(message, innerException) { HResult = HResults.COR_E_IO; } diff --git a/src/libraries/System.Private.CoreLib/src/System/SystemException.cs b/src/libraries/System.Private.CoreLib/src/System/SystemException.cs index b617f7516fe2f2..fca0b0e6a459c6 100644 --- a/src/libraries/System.Private.CoreLib/src/System/SystemException.cs +++ b/src/libraries/System.Private.CoreLib/src/System/SystemException.cs @@ -18,13 +18,13 @@ public SystemException() } public SystemException(string? message) - : base(message ?? SR.Arg_SystemException) + : base(message) { HResult = HResults.COR_E_SYSTEM; } public SystemException(string? message, Exception? innerException) - : base(message ?? SR.Arg_SystemException, innerException) + : base(message, innerException) { HResult = HResults.COR_E_SYSTEM; }