From 54c0756d2015457bdb4762b4fb1e5ab28f880098 Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Wed, 19 Jul 2023 07:18:41 -0400 Subject: [PATCH] Remove unnecessary closures from Logging{Scope}HttpMessageHandler.SendCoreAsync (#89160) * Avoid unnecessary closure in LoggingHttpMessageHandler.SendCoreAsync * Remove unnecessary closure in LoggingScopeHttpMessageHandler.SendCoreAsync --- .../src/Logging/LoggingHttpMessageHandler.cs | 4 ++-- .../src/Logging/LoggingScopeHttpMessageHandler.cs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Http/src/Logging/LoggingHttpMessageHandler.cs b/src/libraries/Microsoft.Extensions.Http/src/Logging/LoggingHttpMessageHandler.cs index c91bc63b82396d..5056474e9ead2f 100644 --- a/src/libraries/Microsoft.Extensions.Http/src/Logging/LoggingHttpMessageHandler.cs +++ b/src/libraries/Microsoft.Extensions.Http/src/Logging/LoggingHttpMessageHandler.cs @@ -50,9 +50,9 @@ public LoggingHttpMessageHandler(ILogger logger, HttpClientFactoryOptions option private Task SendCoreAsync(HttpRequestMessage request, bool useAsync, CancellationToken cancellationToken) { ThrowHelper.ThrowIfNull(request); - return Core(request, cancellationToken); + return Core(request, useAsync, cancellationToken); - async Task Core(HttpRequestMessage request, CancellationToken cancellationToken) + async Task Core(HttpRequestMessage request, bool useAsync, CancellationToken cancellationToken) { Func shouldRedactHeaderValue = _options?.ShouldRedactHeaderValue ?? _shouldNotRedactHeaderValue; diff --git a/src/libraries/Microsoft.Extensions.Http/src/Logging/LoggingScopeHttpMessageHandler.cs b/src/libraries/Microsoft.Extensions.Http/src/Logging/LoggingScopeHttpMessageHandler.cs index d111c04c5c71d4..e170acbfe83c80 100644 --- a/src/libraries/Microsoft.Extensions.Http/src/Logging/LoggingScopeHttpMessageHandler.cs +++ b/src/libraries/Microsoft.Extensions.Http/src/Logging/LoggingScopeHttpMessageHandler.cs @@ -50,9 +50,9 @@ public LoggingScopeHttpMessageHandler(ILogger logger, HttpClientFactoryOptions o private Task SendCoreAsync(HttpRequestMessage request, bool useAsync, CancellationToken cancellationToken) { ThrowHelper.ThrowIfNull(request); - return Core(request, cancellationToken); + return Core(request, useAsync, cancellationToken); - async Task Core(HttpRequestMessage request, CancellationToken cancellationToken) + async Task Core(HttpRequestMessage request, bool useAsync, CancellationToken cancellationToken) { var stopwatch = ValueStopwatch.StartNew();