Move EventLog tests to not run on CI (#32501)

* Move EventLog tests to not run on CI We are hitting Win32 API issues when calling specific EventLog features. As the risk of changes in EventLog is low we decided to turn off some tests in CI and run them manually before a release.
dotnet · Feb 18, 2020 · 48a222c · 48a222c
1 parent ed12fa7
commit 48a222c
Show file tree

Hide file tree

Showing 8 changed files with 40 additions and 3 deletions.
diff --git a/src/libraries/System.Diagnostics.EventLog/tests/EventLogEntryCollectionTests.cs b/src/libraries/System.Diagnostics.EventLog/tests/EventLogEntryCollectionTests.cs
@@ -3,13 +3,15 @@
 // See the LICENSE file in the project root for more information.
 
 using Xunit;
+using Microsoft.DotNet.XUnitExtensions;
 
 namespace System.Diagnostics.Tests
 {
     public class EventLogEntryCollectionTests
     {
         private const string message = "EntryCollectionMessage";
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void CopyingEventLogEntryCollection()
         {
@@ -44,6 +46,7 @@ public void CopyingEventLogEntryCollection()
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void CheckingEntryEqualityWithNull()
         {
@@ -69,6 +72,7 @@ public void CheckingEntryEqualityWithNull()
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void CheckingEntryEqualityAndIndex()
         {
@@ -99,6 +103,7 @@ public void CheckingEntryEqualityAndIndex()
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void CheckingEntryInEquality()
         {

diff --git a/src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogEntryWrittenTest.cs b/src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogEntryWrittenTest.cs
@@ -4,6 +4,7 @@
 
 using System.Threading;
 using Xunit;
+using Microsoft.DotNet.XUnitExtensions;
 
 namespace System.Diagnostics.Tests
 {
@@ -52,13 +53,15 @@ private void RaisingEvent(string log, string methodName, bool waitOnEvent = true
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void EntryWrittenEventRaised()
         {
             RaisingEvent("EnableEvent", nameof(EntryWrittenEventRaised));
             Assert.NotEqual(0, eventCounter);
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void EntryWrittenEventRaiseDisable()
         {

diff --git a/src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogSourceCreationTests.cs b/src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogSourceCreationTests.cs
@@ -3,12 +3,13 @@
 // See the LICENSE file in the project root for more information.
 
 using Xunit;
+using Microsoft.DotNet.XUnitExtensions;
 
 namespace System.Diagnostics.Tests
 {
     public class EventLogSourceCreationTests
     {
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/32241")]
+        [Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void CheckSourceExistenceAndDeletion()
         {
@@ -28,6 +29,7 @@ public void CheckSourceExistenceAndDeletion()
             Assert.False(EventLog.SourceExists(source));
         }
 
+        [Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
         public void LogNameWithSame8FirstChars_NetCore()
@@ -54,6 +56,7 @@ public void LogNameWithSame8FirstChars_NetCore()
             }
         }
 
+        [Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [SkipOnTargetFramework(~TargetFrameworkMonikers.NetFramework)]
         public void LogNameWithSame8FirstChars_NetFramework()
@@ -142,6 +145,7 @@ public void SourceDataNull()
             Assert.Throws<ArgumentNullException>(() => EventLog.CreateEventSource(null));
         }
 
+        [Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void SourceAlreadyExistsWhenCreatingSource()
         {

diff --git a/src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogTests.cs b/src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogTests.cs
@@ -6,6 +6,7 @@
 using System.IO;
 using System.Linq;
 using Xunit;
+using Microsoft.DotNet.XUnitExtensions;
 
 namespace System.Diagnostics.Tests
 {
@@ -22,6 +23,7 @@ public void EventLogReinitializationException()
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void ClearLog()
         {
@@ -57,6 +59,7 @@ public void ApplicationEventLog_Count()
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void DeleteLog()
         {
@@ -128,6 +131,7 @@ public void EventLogs_Get()
             Assert.Contains(eventLogCollection, eventlog => eventlog.Log.Equals("System"));
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void GetMaxKilobytes_Set()
         {
@@ -162,6 +166,7 @@ public void MaxKilobytesOutOfRangeException()
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void OverflowAndRetention_Set()
         {
@@ -190,6 +195,7 @@ public void OverflowAndRetention_Set()
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void Overflow_OverWriteOlderAndRetention_Set()
         {
@@ -248,6 +254,7 @@ public void MachineName_Set()
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void RegisterDisplayLogName()
         {
@@ -314,6 +321,7 @@ public void InvalidMachineName()
             Assert.Throws<ArgumentException>(() => EventLog.DeleteEventSource("", ""));
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void LogDisplayNameDefault()
         {

diff --git a/src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogWriteEntryTests.cs b/src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogWriteEntryTests.cs
@@ -4,6 +4,7 @@
 
 using System.ComponentModel;
 using Xunit;
+using Microsoft.DotNet.XUnitExtensions;
 
 namespace System.Diagnostics.Tests
 {
@@ -121,6 +122,7 @@ private EventLogEntry WriteLogEntryEvent(string source, bool data = false)
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalTheory(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [InlineData(false)]
         [InlineData(true)]
@@ -153,6 +155,7 @@ public void WriteEntry(bool sourceFlag)
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalTheory(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [InlineData(false)]
         [InlineData(true)]
@@ -182,6 +185,7 @@ public void WriteEntryWithType(bool sourceFlag)
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalTheory(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [InlineData(false)]
         [InlineData(true)]
@@ -211,6 +215,7 @@ public void WriteEntryWithTypeAndId(bool sourceFlag)
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalTheory(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [InlineData(false)]
         [InlineData(true)]
@@ -246,6 +251,7 @@ public void WriteEntryWithTypeIdAndCategory(bool sourceFlag)
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalTheory(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [InlineData(false)]
         [InlineData(true)]
@@ -302,6 +308,7 @@ public void WriteEntryWithNullOrEmptySource()
             Assert.Throws<ArgumentException>(() => EventLog.WriteEntry("", message));
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalTheory(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [InlineData(false)]
         [InlineData(true)]
@@ -328,6 +335,7 @@ public void WriteEvent(bool SourceFlag)
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalTheory(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [InlineData(false)]
         [InlineData(true)]

diff --git a/src/libraries/System.Diagnostics.EventLog/tests/EventLogTraceListenerTests.cs b/src/libraries/System.Diagnostics.EventLog/tests/EventLogTraceListenerTests.cs
@@ -7,6 +7,7 @@
 using System.Globalization;
 using System.Text;
 using Xunit;
+using Microsoft.DotNet.XUnitExtensions;
 
 namespace System.Diagnostics.Tests
 {
@@ -87,6 +88,7 @@ public void CloseSucceeds()
                 listener.Close(); // shouldn't fail.
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void WriteTest()
         {
@@ -113,7 +115,7 @@ public void WriteTest()
             }
         }
 
-        [ActiveIssue("https://github.com/dotnet/corefx/issues/40224", TestPlatforms.Windows)]
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalTheory(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [InlineData(TraceEventType.Information, EventLogEntryType.Information, ushort.MaxValue + 1, ushort.MaxValue)]
         [InlineData(TraceEventType.Error, EventLogEntryType.Error, ushort.MinValue - 1, ushort.MinValue)]
@@ -155,6 +157,7 @@ public static IEnumerable<object[]> GetTraceDataParams_MemberData()
             yield return new object[] { new object[] { "one string + null", null } };
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalTheory(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [MemberData(nameof(GetTraceDataParams_MemberData))]
         public void TraceDataParamsData(object[] parameters)
@@ -195,7 +198,7 @@ public static IEnumerable<object[]> GetTraceEventFormat_MemberData()
             yield return new object[] { null, new object[] { "thanks, 00", "i like it...", 111 } };
         }
 
-        [ActiveIssue("https://github.com/dotnet/corefx/issues/40224", TestPlatforms.Windows)]
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalTheory(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [MemberData(nameof(GetTraceEventFormat_MemberData))]
         public void TraceEventFormatAndParams(string format, object[] parameters)
@@ -251,6 +254,7 @@ public void TraceEventFormatAndParams(string format, object[] parameters)
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void TraceWithFilters()
         {

diff --git a/...raries/System.Diagnostics.EventLog/tests/System/Diagnostics/Reader/EventLogRecordTests.cs b/...raries/System.Diagnostics.EventLog/tests/System/Diagnostics/Reader/EventLogRecordTests.cs
@@ -6,6 +6,7 @@
 using System.Diagnostics.Eventing.Reader;
 using System.Security.Principal;
 using Xunit;
+using Microsoft.DotNet.XUnitExtensions;
 
 namespace System.Diagnostics.Tests
 {
@@ -29,6 +30,7 @@ public void GetPropertyValues()
         }
 
         [ActiveIssue("https://github.com/dotnet/corefx/issues/34547")]
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalTheory(typeof(Helpers), nameof(Helpers.SupportsEventLogs))]
         [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
         [InlineData("System")]

diff --git a/...aries/System.Diagnostics.EventLog/tests/System/Diagnostics/Reader/EventLogWatcherTests.cs b/...aries/System.Diagnostics.EventLog/tests/System/Diagnostics/Reader/EventLogWatcherTests.cs
@@ -5,6 +5,7 @@
 using System.Diagnostics.Eventing.Reader;
 using System.Threading;
 using Xunit;
+using Microsoft.DotNet.XUnitExtensions;
 
 namespace System.Diagnostics.Tests
 {
@@ -94,13 +95,15 @@ private void RaisingEvent(string log, string methodName, bool waitOnEvent = true
             }
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void RecordWrittenEventRaised()
         {
             RaisingEvent("EnableEvent", nameof(RecordWrittenEventRaised));
             Assert.NotEqual(0, eventCounter);
         }
 
+        [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // Unreliable Win32 API call
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void RecordWrittenEventRaiseDisable()
         {