From 2f75e690cbdee79108ebc5f765581504025c7430 Mon Sep 17 00:00:00 2001 From: Santiago Fernandez Madero Date: Wed, 13 May 2020 14:28:55 -0700 Subject: [PATCH] Disable System.Diagnostics.Tests.EventLogSourceCreationTests (#36138) * Disable System.Diagnostics.Tests.EventLogSourceCreationTests.CheckSourceExistenceAndDeletion * Fix trait to skip tests in CI * Use ActiveIssue instead --- .../tests/EventLogTests/EventLogSourceCreationTests.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogSourceCreationTests.cs b/src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogSourceCreationTests.cs index 29bfba9dcbe8b4..fc2e0f33ce959d 100644 --- a/src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogSourceCreationTests.cs +++ b/src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogSourceCreationTests.cs @@ -9,7 +9,7 @@ namespace System.Diagnostics.Tests { public class EventLogSourceCreationTests { - [Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call + [ActiveIssue("https://github.com/dotnet/runtime/issues/36135")] [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))] public void CheckSourceExistenceAndDeletion() { @@ -29,7 +29,7 @@ public void CheckSourceExistenceAndDeletion() Assert.False(EventLog.SourceExists(source)); } - [Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call + [ActiveIssue("https://github.com/dotnet/runtime/issues/36135")] [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] public void LogNameWithSame8FirstChars_NetCore() @@ -56,7 +56,7 @@ public void LogNameWithSame8FirstChars_NetCore() } } - [Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call + [ActiveIssue("https://github.com/dotnet/runtime/issues/36135")] [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))] [SkipOnTargetFramework(~TargetFrameworkMonikers.NetFramework)] public void LogNameWithSame8FirstChars_NetFramework() @@ -145,7 +145,7 @@ public void SourceDataNull() Assert.Throws(() => EventLog.CreateEventSource(null)); } - [Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call + [ActiveIssue("https://github.com/dotnet/runtime/issues/36135")] [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))] public void SourceAlreadyExistsWhenCreatingSource() {