Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LSP RequestMetrics based telemetry reporting #68790

Open
genlu opened this issue Jun 26, 2023 · 3 comments
Open

Fix LSP RequestMetrics based telemetry reporting #68790

genlu opened this issue Jun 26, 2023 · 3 comments
Assignees
@genlu @dibarbet
Labels
Area-Analyzers LSP issues related to the roslyn language server protocol implementation Tenet-Telemetry Our ability to collect telemetry is broken.
Milestone
Backlog

Comments

@genlu
Copy link
Member

genlu commented Jun 26, 2023

We used to report telemetry for LSP request handling with this:
https://sourceroslyn.io/#Microsoft.CodeAnalysis.LanguageServer.Protocol/Handler/RequestMetrics.cs,dbc0f7ecd3f54f1a

However, it was (probably accidentally) removed as part of this PR. We'd like to reinstate it to collect perf data for various request handler again.
@genlu genlu added Tenet-Telemetry Our ability to collect telemetry is broken. LSP issues related to the roslyn language server protocol implementation labels Jun 26, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 26, 2023
@genlu
Copy link
Member Author

genlu commented Jun 26, 2023

FYI @dibarbet @arkalyanms
Also @phil-allen-msft since fixing this might require change in Razor as well

@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 26, 2023
@arunchndr arunchndr added this to the 17.7 P4 milestone Jun 26, 2023
@genlu genlu mentioned this issue Jun 26, 2023
Closed
@dibarbet
Copy link
Member

dibarbet commented Dec 4, 2023

Once this is fixed AND the Xaml changes are in, we'll need to update this to include which language the request was for

@ToddGrun
Copy link
Contributor

First part of this is in (only sends the server name, not the language name) here:

#71157

@arunchndr arunchndr modified the milestones: 17.7 P4, Backlog Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@genlu genlu

@dibarbet dibarbet

Labels
Area-Analyzers LSP issues related to the roslyn language server protocol implementation Tenet-Telemetry Our ability to collect telemetry is broken.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@genlu @dibarbet @ToddGrun @arunchndr