Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# editor should provide a collapsable region for comments #68579

Closed
vsfeedback opened this issue Jun 13, 2023 · 4 comments · Fixed by #76865
Closed

C# editor should provide a collapsable region for comments #68579

vsfeedback opened this issue Jun 13, 2023 · 4 comments · Fixed by #76865
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Structure (Outlining)
Milestone

Comments

@vsfeedback
Copy link

This issue has been moved from a ticket on Developer Community.


The comments are such as // or /* ... */ should be collapsableI would expect a "+" appears on the left margin so that long portions of commented code (more than one line) can be collapsed as it normally happens with 'summaries' over the types and members (triple slash ///)


Original Comments

Fiona Niu [MSFT] on 10/12/2018, 03:38 AM:

(private comment, text removed)

Kendra Havens [MSFT] on 10/31/2018, 00:25 PM:

(private comment, text removed)

Drew Noakes [MSFT] on 5/22/2019, 05:15 PM:

(private comment, text removed)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 13, 2023
@sharwell
Copy link
Member

📝 This already works for long comments in the body of a type, but doesn't work for comments nested inside a member. For example, the following comment can be collapsed:

class T
{
  //
  //
  //
}

but the following comment cannot:

class T
{
  void Method()
  {
    //
    //
    //
  }
}

@arunchndr arunchndr added Structure (Outlining) Feature Request and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 15, 2023
@arunchndr arunchndr added this to the Backlog milestone Aug 15, 2023
@tamlin-mike
Copy link

I understand it has only been half a decade, but please...

I find tagging this "Feature Request" both absurd and insulting - it's a core functionality in any other code editor with any kind of self respect in the last decades (actually, I recall an editor from the 80's having it, and having it work properly). To mess something as basic as this up is a bug, nothing else.
Unless one considers e.g. "Stop crashing" a "Feature" - in that case all hope is lost.

This is such basic functionality it baffles the mind how it could have been left messed up like this, for this long.

@CyrusNajmabadi CyrusNajmabadi added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Sep 16, 2023
@CyrusNajmabadi
Copy link
Member

I understand it has only been half a decade, but please...

It has been half a decade, with a single person filing the issue, and now a single person commenting on it. We prioritize the feature requests that are made based on things like how much of our community wants something, and this is near the bottom of the list.

Note: if you would like to contribute a fix here, we'd happily work with you on that. However, this is currently on the backlog and would be done by us after many other, much more important issues that are impacting our userbase.

To mess something as basic as this up is a bug, nothing else.

Every feature has bugs. Such is life. The language is huge and sprawling, and we can either invest all our efforts in a few areas to stamp out all the bugs there, or we can provide the gamut of features that customers want (at this point, several thousand) but recognize that bugs will be there, and they will be prioritized based on impact and community need.

Fortunately though, this is all open source. If this is something you want fixed @tamlin-mike, it's something you can invest into, and see the results immediately with. In other words, while this is currently on our backlog, it doesn't have to be on your backlog if you think this is that important :)

This is such basic functionality it baffles the mind how it could have been left messed up like this, for this long.

Because there was literally one complaint in 5 years. It would be a massive waste of resources to invest in fixing when there are literally hundreds to thousands of other issues with far higher impact and far more demand from our community to get attention. Being open source though opens up the possibility for the community to themselves be involved here. :)

@sharwell
Copy link
Member

sharwell commented Sep 18, 2023

@tamlin-mike it's not a bug because it wasn't originally intended to be present (since it could clutter the margin), a decisions which was subsequently confirmed by the lack of requests for it to be added. I changed to the Continuous Improvement label which better reflects issues for small changes to designs based on user feedback over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Structure (Outlining)
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants