Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roslyn should have an ETW/EventPipe source that we can use to report data #54770

Closed
chsienki opened this issue Jul 12, 2021 · 1 comment · Fixed by #55892
Closed

Roslyn should have an ETW/EventPipe source that we can use to report data #54770

chsienki opened this issue Jul 12, 2021 · 1 comment · Fixed by #55892
Assignees
@chsienki
Labels
api-approved API was approved in API review, it can be implemented Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API.
Milestone
17.0

Comments

@chsienki
Copy link
Member

In certain situations it would be very useful to report data via ETW/LTTNG. The event source class allows this is in a cross platform, high performance way; tools like PerfView and dotnet-trace can then be used to read the information back from a release compiler with low impact on regular throughput.

We should create a central class that can be used across the roslyn stack to report such data.
@chsienki chsienki self-assigned this Jul 12, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 12, 2021
@jaredpar jaredpar added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 13, 2021
@jaredpar jaredpar added this to the 17.0 milestone Jul 13, 2021
@chsienki chsienki modified the milestones: 17.0, 17.1 Aug 13, 2021
@chsienki chsienki modified the milestones: 17.1, 17.0 Aug 23, 2021
@chsienki chsienki mentioned this issue Aug 25, 2021
Merged
@333fred 333fred added api-approved API was approved in API review, it can be implemented Concept-API This issue involves adding, removing, clarification, or modification of an API. labels Aug 25, 2021
@333fred
Copy link
Member

333fred commented Aug 25, 2021

API Review

Should be ElapsedTime, otherwise the API proposed in #55892 looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chsienki chsienki

Labels
api-approved API was approved in API review, it can be implemented Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API.
Projects
None yet
Milestone
17.0
Development

Successfully merging a pull request may close this issue.

Source generators/timing chsienki/roslyn
3 participants
@jaredpar @333fred @chsienki