Rename NewLinesForBracesInObjectCollectionArrayInitializers to NewLinesForBracesInExpressions

[tiesmaster]

Split off from #36913, as mentioned by @sharwell:

Design review conclusion:

• For fixing this issue (Fix brace code style for switch expressions #39396), we should use NewLinesForBracesInObjectCollectionArrayInitializers. Done in Add brace new line code style for switch expressions #36913
• We should rename NewLinesForBracesInObjectCollectionArrayInitializers to NewLinesForBracesInExpressions, and update the Tools → Options and .editorconfig strings to reflect this change. @tiesmaster has the option of implementing this in Fix brace code style for switch expressions #39396, or we can implement it separately.
• We should verify that pattern matching braces are also controlled by NewLinesForBracesInExpressions.

[tiesmaster]

@sharwell I'm going to try to tackle this, however, I was wondering if any backwards compatibility needs to be taken into account? And if so, how?

[sharwell]

@tiesmaster We already renamed this .editorconfig property once. You can approach it the same way. Here's the old property from the first time:

roslyn/src/Workspaces/CSharp/Portable/Formatting/CSharpFormattingOptions.cs

Line 51 in d025402

KeyValuePairUtil.Create("object_collection_array_initalizers", NewLineOption.ObjectCollectionsArrayInitializers),

[CyrusNajmabadi]

Closing out as speculative and due to no movement.