Merge remote-tracking branch 'dotnet/main' into value-builder

Author: sharwell

.devcontainer/Dockerfile

@@ -1,8 +1,6 @@
 # See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.192.0/containers/dotnet/.devcontainer/base.Dockerfile
 
-# [Choice] .NET version: 6.0, 5.0, 3.1, 2.1
-ARG VARIANT="6.0"
-FROM mcr.microsoft.com/vscode/devcontainers/dotnet:0-${VARIANT}
+FROM mcr.microsoft.com/vscode/devcontainers/dotnet:8.0
 
 # Set up machine requirements to build the repo
 RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \

.devcontainer/devcontainer.json

@@ -1,56 +1,59 @@
 // For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
 // https://github.com/microsoft/vscode-dev-containers/tree/v0.140.1/containers/dotnetcore
 {
-  "name": "C# (.NET 6)",
+  "name": "C# (.NET 8)",
   "build": {
     "dockerfile": "Dockerfile",
-    "args": {
-      "VARIANT": "6.0",
-    }
   },
-  "settings": {
-    "files.associations": {
-      "*.csproj": "msbuild",
-      "*.fsproj": "msbuild",
-      "*.globalconfig": "ini",
-      "*.manifest": "xml",
-      "*.nuspec": "xml",
-      "*.pkgdef": "ini",
-      "*.projitems": "msbuild",
-      "*.props": "msbuild",
-      "*.resx": "xml",
-      "*.rsp": "Powershell",
-      "*.ruleset": "xml",
-      "*.settings": "xml",
-      "*.shproj": "msbuild",
-      "*.slnf": "json",
-      "*.targets": "msbuild",
-      "*.vbproj": "msbuild",
-      "*.vsixmanifest": "xml",
-      "*.vstemplate": "xml",
-      "*.xlf": "xml",
-      "*.yml": "azure-pipelines"
-    },
-    // ms-dotnettools.csharp settings
-    "omnisharp.defaultLaunchSolution": "Compilers.sln",
-    "omnisharp.disableMSBuildDiagnosticWarning": true,
-    "omnisharp.enableEditorConfigSupport": true,
-    "omnisharp.enableImportCompletion": true,
-    "omnisharp.useModernNet": true,
-    "omnisharp.enableAsyncCompletion": true,
-    // ms-vscode.powershell settings
-    "powershell.promptToUpdatePowerShell": false,
-    "powershell.integratedConsole.showOnStartup": false,
-    "powershell.startAutomatically": false,
-    // ms-azure-devops.azure-pipelines settings
-    "azure-pipelines.customSchemaFile": ".vscode/dnceng-schema.json"
+  "customizations": {
+    "vscode": {
+      "settings": {
+        "files.associations": {
+          "*.csproj": "msbuild",
+          "*.fsproj": "msbuild",
+          "*.globalconfig": "ini",
+          "*.manifest": "xml",
+          "*.nuspec": "xml",
+          "*.pkgdef": "ini",
+          "*.projitems": "msbuild",
+          "*.props": "msbuild",
+          "*.resx": "xml",
+          "*.rsp": "Powershell",
+          "*.ruleset": "xml",
+          "*.settings": "xml",
+          "*.shproj": "msbuild",
+          "*.slnf": "json",
+          "*.targets": "msbuild",
+          "*.vbproj": "msbuild",
+          "*.vsixmanifest": "xml",
+          "*.vstemplate": "xml",
+          "*.xlf": "xml",
+          "*.yml": "azure-pipelines"
+        },
+        // ms-dotnettools.csharp settings
+        "omnisharp.disableMSBuildDiagnosticWarning": true,
+        "omnisharp.enableEditorConfigSupport": true,
+        "omnisharp.enableImportCompletion": true,
+        "omnisharp.useModernNet": true,
+        "omnisharp.enableAsyncCompletion": true,
+        // ms-dotnettools.csdevkit settings
+        "dotnet.defaultSolution": "Roslyn.sln",
+        // ms-vscode.powershell settings
+        "powershell.promptToUpdatePowerShell": false,
+        "powershell.integratedConsole.showOnStartup": false,
+        "powershell.startAutomatically": false,
+        // ms-azure-devops.azure-pipelines settings
+        "azure-pipelines.customSchemaFile": ".vscode/dnceng-schema.json"
+      },
+      "extensions": [
+        "ms-dotnettools.csharp",
+        "ms-dotnettools.csdevkit",
+        "EditorConfig.EditorConfig",
+        "ms-vscode.powershell",
+        "tintoy.msbuild-project-tools",
+        "ms-azure-devops.azure-pipelines"
+      ]
+    }
   },
-  "extensions": [
-    "ms-dotnettools.csharp",
-    "EditorConfig.EditorConfig",
-    "ms-vscode.powershell",
-    "tintoy.msbuild-project-tools",
-    "ms-azure-devops.azure-pipelines"
-  ],
   "postCreateCommand": "${containerWorkspaceFolder}/restore.sh"
 }

.editorconfig

@@ -7,6 +7,7 @@ root = true
 [*]
 indent_style = space
 # (Please don't specify an indent_size here; that has too many unintended consequences.)
+spelling_exclusion_path = SpellingExclusions.dic
 
 # Code files
 [*.{cs,csx,vb,vbx}]
@@ -38,9 +39,6 @@ indent_size = 2
 # Dotnet code style settings:
 [*.{cs,vb}]
 
-# IDE0055: Fix formatting
-dotnet_diagnostic.IDE0055.severity = warning
-
 # Sort using and Import directives with System.* appearing first
 dotnet_sort_system_directives_first = true
 dotnet_separate_import_directive_groups = false
@@ -144,35 +142,15 @@ dotnet_naming_symbols.all_members.applicable_kinds = *
 
 dotnet_naming_style.pascal_case_style.capitalization = pascal_case
 
-# error RS2008: Enable analyzer release tracking for the analyzer project containing rule '{0}'
-dotnet_diagnostic.RS2008.severity = none
-
-# IDE0073: File header
-dotnet_diagnostic.IDE0073.severity = warning
 file_header_template = Licensed to the .NET Foundation under one or more agreements.\nThe .NET Foundation licenses this file to you under the MIT license.\nSee the LICENSE file in the project root for more information.
 
-# IDE0035: Remove unreachable code
-dotnet_diagnostic.IDE0035.severity = warning
-
-# IDE0036: Order modifiers
-dotnet_diagnostic.IDE0036.severity = warning
-
-# IDE0043: Format string contains invalid placeholder
-dotnet_diagnostic.IDE0043.severity = warning
-
-# IDE0044: Make field readonly
-dotnet_diagnostic.IDE0044.severity = warning
-
-# CONSIDER: Are IDE0051 and IDE0052 too noisy to be warnings for IDE editing scenarios? Should they be made build-only warnings?
-# IDE0051: Remove unused private member
-dotnet_diagnostic.IDE0051.severity = warning
-
-# IDE0170: Prefer extended property pattern
-dotnet_diagnostic.IDE0170.severity = warning
-
 # RS0016: Only enable if API files are present
 dotnet_public_api_analyzer.require_api_files = true
 
+# IDE0055: Fix formatting
+# Workaround for https://github.com/dotnet/roslyn/issues/70570
+dotnet_diagnostic.IDE0055.severity = warning
+
 # CSharp code style settings:
 [*.cs]
 # Newline settings
@@ -196,6 +174,8 @@ csharp_indent_labels = flush_left
 csharp_style_allow_embedded_statements_on_same_line_experimental = false
 csharp_style_allow_blank_lines_between_consecutive_braces_experimental = false
 csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = false
+csharp_style_allow_blank_line_after_token_in_conditional_expression_experimental = false
+csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimental = false
 
 # Prefer "var" everywhere
 csharp_style_var_for_built_in_types = true:suggestion
@@ -249,6 +229,14 @@ csharp_prefer_braces = true:silent
 csharp_preserve_single_line_blocks = true
 csharp_preserve_single_line_statements = true
 
+# IDE0060: Remove unused parameter
+dotnet_diagnostic.IDE0060.severity = warning
+
+[src/{Compilers,ExpressionEvaluator,Scripting}/**Test**/*.{cs,vb}]
+
+# IDE0060: Remove unused parameter
+dotnet_diagnostic.IDE0060.severity = none
+
 [src/{Analyzers,CodeStyle,Features,Workspaces,EditorFeatures,VisualStudio}/**/*.{cs,vb}]
 
 # IDE0011: Add braces
@@ -265,9 +253,6 @@ dotnet_diagnostic.IDE0052.severity = warning
 # IDE0059: Unnecessary assignment to a value
 dotnet_diagnostic.IDE0059.severity = warning
 
-# IDE0060: Remove unused parameter
-dotnet_diagnostic.IDE0060.severity = warning
-
 # CA1012: Abstract types should not have public constructors
 dotnet_diagnostic.CA1012.severity = warning
 
@@ -280,21 +265,21 @@ csharp_style_var_for_built_in_types = true:warning
 csharp_style_var_when_type_is_apparent = true:warning
 csharp_style_var_elsewhere = true:warning
 
-# dotnet_style_allow_multiple_blank_lines_experimental
-dotnet_diagnostic.IDE2000.severity = warning
-
 # csharp_style_allow_embedded_statements_on_same_line_experimental
 dotnet_diagnostic.IDE2001.severity = warning
 
 # csharp_style_allow_blank_lines_between_consecutive_braces_experimental
 dotnet_diagnostic.IDE2002.severity = warning
 
-# dotnet_style_allow_statement_immediately_after_block_experimental
-dotnet_diagnostic.IDE2003.severity = warning
-
 # csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental
 dotnet_diagnostic.IDE2004.severity = warning
 
+# csharp_style_allow_blank_line_after_token_in_conditional_expression_experimental
+dotnet_diagnostic.IDE2005.severity = warning
+
+# csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimental
+dotnet_diagnostic.IDE2006.severity = warning
+
 [src/{VisualStudio}/**/*.{cs,vb}]
 # CA1822: Make member static
 # There is a risk of accidentally breaking an internal API that partners rely on though IVT.

.git-blame-ignore-revs

@@ -1,4 +1,12 @@
 # dotnet-format -w Roslyn.sln on June 18, 2021
 abce41d282ac631be5217140f1bd46d0e250ad02
 fbdb56063e761643707f6bc1e1ba469f6fb9a31a
-57278e7dcbf7bffb310e8b14105f657f0fdbab78
+57278e7dcbf7bffb310e8b14105f657f0fdbab78
+# Converting to file scoped namespaces on 2/27/2024. https://github.com/dotnet/roslyn/pull/72294
+ec6c8b40e23a595b1e75aec920e3fb29e55f61cf
+de42965cf9b64d71bccc549dd9940210cda5abf1
+4262648cadff59cc703b6be8c00b9814a6b13c5a
+17e64d5773140ae5813664932bbfa4722a983805
+3f632c70e8e28a5ede881784600d0f3d06d3138d
+27b50978f636ac0588ea7c19664fac4502e964a7
+f125c2664d3bffb59536f4d3dfee7fa5323c7721

.github/CODEOWNERS

@@ -8,6 +8,7 @@ docs/compilers @dotnet/roslyn-compiler
 docs/ide @dotnet/roslyn-ide
 
 eng/ @dotnet/roslyn-infrastructure
+eng/SourceBuild* @dotnet/source-build-internal
 scripts/ @dotnet/roslyn-infrastructure
 
 src/Analyzers/ @dotnet/roslyn-ide
@@ -18,27 +19,30 @@ src/Compilers/ @dotnet/roslyn-compiler
 # to happen.
 src/Compilers/Test/Core/Traits/Traits.cs
 src/EditorFeatures/ @dotnet/roslyn-ide
-
-# If we touch the WPF layer or Cocoa layers, the VS for Mac team also should take a look. We do this even if it's
-# only touching WPF since the change might also need to be made (and validated) on the Cocoa side of things.
-src/EditorFeatures/Core.Cocoa/ @dotnet/roslyn-ide @dotnet/roslyn-vs-for-mac
-src/EditorFeatures/Core.Wpf/ @dotnet/roslyn-ide @dotnet/roslyn-vs-for-mac
-src/EditorFeatures/CSharp.Wpf/ @dotnet/roslyn-ide @dotnet/roslyn-vs-for-mac
-
 src/Features/ @dotnet/roslyn-ide
 src/Interactive/ @dotnet/roslyn-interactive
 src/NuGet/ @dotnet/roslyn-infrastructure
 src/Scripting/ @dotnet/roslyn-interactive
 src/Setup/ @dotnet/roslyn-infrastructure
-src/Tools/ @dotnet/roslyn-infrastructure
+src/Tools/AnalyzerRunner @dotnet/roslyn-ide
+src/Tools/BuildActionTelemetryTable @dotnet/roslyn-infrastructure
+src/Tools/BuildBoss @dotnet/roslyn-infrastructure
+src/Tools/BuildValidator @dotnet/roslyn-infrastructure
+src/Tools/dotnet-format @dotnet/roslyn-infrastructure
+src/Tools/ExternalAccess @dotnet/roslyn-ide
+src/Tools/IdeBenchmarks @dotnet/roslyn-ide
+src/Tools/IdeCoreBenchmarks @dotnet/roslyn-ide
+src/Tools/ManifestGenerator @dotnet/roslyn-infrastructure
+src/Tools/PrepareTests @dotnet/roslyn-infrastructure
 src/Tools/Source/CompilerGeneratorTools/ @dotnet/roslyn-compiler
+src/Tools/Source/RunTests @dotnet/roslyn-infrastructure
 src/VisualStudio/ @dotnet/roslyn-ide
-src/VisualStudio/LiveShare @dotnet/roslyn-ide @daytonellwanger @srivatsn @aletsdelarosa
 src/Workspaces/ @dotnet/roslyn-ide
 
 src/Compilers/**/PublicAPI.Unshipped.txt @dotnet/roslyn-api-owners
 src/Workspaces/**/PublicAPI.Unshipped.txt @dotnet/roslyn-api-owners
 src/Features/**/PublicAPI.Unshipped.txt @dotnet/roslyn-api-owners
 src/EditorFeatures/**/PublicAPI.Unshipped.txt @dotnet/roslyn-api-owners
 
-src/Tools/ExternalAccess/OmniSharp*/ @333fred @joerobich
+src/Tools/ExternalAccess/OmniSharp*/ @333fred @dibarbet
+src/Tools/ExternalAccess/CompilerDeveloperSDK/ @333fred

.github/ISSUE_TEMPLATE/bug-report.md

@@ -11,7 +11,11 @@ about: Report a bug in Roslyn
 2. 
 3. 
 
-(A [sharplab](https://sharplab.io/) repro is ideal for compiler/language issues whenever possible)
+A minimal repro, with source-code provided, is ideal.  Using [sharplab](https://sharplab.io/) is preferred for compiler/language issues whenever possible.
+
+**Diagnostic Id**:
+
+If this is a report about a bug in an analyzer, please include the diagnostic if possible (e.g. `"IDE0030"`).
 
 **Expected Behavior**:
 

.github/ISSUE_TEMPLATE/localization-suggestion.md

@@ -0,0 +1,47 @@
+---
+name: Localization suggestion
+about: Suggest a change to a localized string.
+labels: [Area-Infrastructure, Tenet-Localization]
+---
+
+## Repo URL where the string lives
+
+https://github.com/dotnet/roslyn
+
+## File Name
+
+<!-- A github link to the .xlf file or files with the problematic translation. -->
+
+## Resource ID
+
+<!-- The ResourceID from `<trans-unit id="{ResourceID}">`. -->
+
+## English String
+
+<!-- The EnglishString from `<source>{EnglishString}</source>`. -->
+
+## Current Translation
+
+<!-- The CurrentTranslation from `<target state="translated">{CurrentTranslation}</target>`. -->
+
+## Suggested Translation
+
+<!-- The suggested translation. -->
+
+## Language
+
+<!-- The language of the problematic translation. -->
+
+## Why Fix is needed
+
+<!-- A brief explanation of why the current translation is not appropriate. -->
+
+
+
+<!-- Do not make changes below this line. -->
+--- 
+## Roslyn Team Instructions
+
+A Roslyn team member will file a bug through https://aka.ms/ceLocBug which the translation team will consider.
+
+Internal Tracking Issue: {Update with tracking issue URL.}