Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of obsolete preprocessor symbols #1905

Closed
idg10 opened this issue Mar 30, 2023 · 0 comments · Fixed by #1915
Closed

Remove use of obsolete preprocessor symbols #1905

idg10 opened this issue Mar 30, 2023 · 0 comments · Fixed by #1915
Assignees
Milestone

Comments

@idg10
Copy link
Collaborator

idg10 commented Mar 30, 2023

As https://github.com/dotnet/reactive/blob/main/Rx.NET/Documentation/adr/0001-net7.0-era-tooling-update.md#out-of-support-tfms-1 describes, there are numerous places in the code that use conditional compilation with preprocessor constants that are no longer relevant. These sections were added back when we targetted older runtimes and lower versions of .NET Standard.

They now serve no purpose, and just add complication and clutter to the build. We should remove all conditional compilation based on these now-irrelevant symbols.

@idg10 idg10 added this to the Rx 6.0 milestone Mar 30, 2023
@idg10 idg10 self-assigned this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant