Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync IO using async file handles #1854

Merged
merged 1 commit into from
Jun 16, 2021
Merged

sync IO using async file handles #1854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/benchmarks/micro/libraries/System.IO.FileSystem/Perf.FileStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public bool OpenClose(long fileSize, FileOptions options)
string filePath = _sourceFilePaths[fileSize];
using (FileStream fileStream = new FileStream(filePath, FileMode.Open, FileAccess.Read, FileShare.Read, FourKibibytes, options))
{
return fileStream.IsAsync; // return something just to consume the reader
return fileStream.IsAsync; // return something just to consume the stream
}
}

Expand Down Expand Up @@ -157,17 +157,23 @@ public void WriteByte(long fileSize, FileOptions options)
public IEnumerable<object[]> SyncArguments()
{
// long fileSize, int userBufferSize, FileOptions options
yield return new object[] { OneKibibyte, OneKibibyte, FileOptions.None }; // small file size, user buffer size == file size
yield return new object[] { OneMibibyte, HalfKibibyte, FileOptions.None }; // medium size file, user buffer size * 8 == default stream buffer size (buffering is beneficial)
yield return new object[] { OneMibibyte, FourKibibytes, FileOptions.None }; // medium size file, user buffer size == default stream buffer size (buffering is not beneficial)
yield return new object[] { HundredMibibytes, FourKibibytes, FileOptions.None }; // big file, user buffer size == default stream buffer size (buffering is not beneficial)
foreach (FileOptions options in new FileOptions[] { FileOptions.None, FileOptions.Asynchronous })
{
yield return new object[] { OneKibibyte, OneKibibyte, options }; // small file size, user buffer size == file size
yield return new object[] { OneMibibyte, HalfKibibyte, options }; // medium size file, user buffer size * 8 == default stream buffer size (buffering is beneficial)
yield return new object[] { OneMibibyte, FourKibibytes, options }; // medium size file, user buffer size == default stream buffer size (buffering is not beneficial)
yield return new object[] { HundredMibibytes, FourKibibytes, options }; // big file, user buffer size == default stream buffer size (buffering is not beneficial)
}
}

public IEnumerable<object[]> SyncArguments_NoBuffering()
{
// long fileSize, int userBufferSize, FileOptions options
yield return new object[] { OneMibibyte, SixteenKibibytes, FileOptions.None }; // medium size file, user buffer size == 4 * default stream buffer size
yield return new object[] { HundredMibibytes, SixteenKibibytes, FileOptions.None }; // big file, user buffer size == 4 * default stream buffer size
foreach (FileOptions options in new FileOptions[] { FileOptions.None, FileOptions.Asynchronous })
{
yield return new object[] { OneMibibyte, SixteenKibibytes, options }; // medium size file, user buffer size == 4 * default stream buffer size
yield return new object[] { HundredMibibytes, SixteenKibibytes, options }; // big file, user buffer size == 4 * default stream buffer size
}
}

[Benchmark]
Expand Down