Find ref asms after ResolveReferences (#2139) #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3a3d69 added a new FindReferenceAssembliesForReferences target, which ran just before ResolveReferences. Dogfooding this revealed targets in the VS SDK (at least) that manipulate @(ReferencePath) and are hooked in as AfterTargets of ResolveReferences. That was silently ignored, corrupting the user's build. Fixes dotnet#2134 by moving FindReferenceAssembliesForReferences later in the process, so anyone hooking ResolveReferences will see the changes they make in the compiler. This is not a fully general solution to the problem that someone might hook an arbitrary point and manipulate @(ReferencePath), but it unbreaks an obvious hook point.
AndyGerlicher
approved these changes
May 31, 2017
|
@dotnet-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2139 to the vs15.3-preview2 branch. Will need escrow approval.