From 2fc1a27900f67290825705f3583c337da2e44c24 Mon Sep 17 00:00:00 2001 From: Shane Neuville Date: Mon, 13 Dec 2021 16:03:21 -0600 Subject: [PATCH 1/4] Try with a delay --- .../DeviceTests/Tests/Screenshot_Tests.cs | 28 +++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs b/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs index 67759376eaec..86d9bfeac3f8 100644 --- a/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs +++ b/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs @@ -11,7 +11,19 @@ public class Screenshot_Tests [Fact] public async Task GetPngScreenshot() { - var mediaFile = await Screenshot.CaptureAsync(); + ScreenshotResult mediaFile = null; + + for (int i = 0; i < 2; i++) + { + try + { + mediaFile = await Screenshot.CaptureAsync(); + break; + } + catch { } + await Task.Delay(1000); + } + var png = await mediaFile.OpenReadAsync(ScreenshotFormat.Png); Assert.True(png.Length > 0); } @@ -19,7 +31,19 @@ public async Task GetPngScreenshot() [Fact] public async Task GetJpegScreenshot() { - var mediaFile = await Screenshot.CaptureAsync(); + ScreenshotResult mediaFile = null; + + for (int i = 0; i < 2; i++) + { + try + { + mediaFile = await Screenshot.CaptureAsync(); + break; + } + catch { } + await Task.Delay(1000); + } + var png = await mediaFile.OpenReadAsync(ScreenshotFormat.Jpeg); Assert.True(png.Length > 0); } From 09633ea2a6c89b77d0c671689697c61b663bbd25 Mon Sep 17 00:00:00 2001 From: Shane Neuville Date: Wed, 15 Dec 2021 15:57:27 -0600 Subject: [PATCH 2/4] - execute on main thread --- .../DeviceTests/Tests/Screenshot_Tests.cs | 42 ++++++------------- 1 file changed, 12 insertions(+), 30 deletions(-) diff --git a/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs b/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs index 86d9bfeac3f8..2040b86d6c02 100644 --- a/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs +++ b/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs @@ -9,43 +9,25 @@ namespace Microsoft.Maui.Essentials.DeviceTests public class Screenshot_Tests { [Fact] - public async Task GetPngScreenshot() + public Task GetPngScreenshot() { - ScreenshotResult mediaFile = null; - - for (int i = 0; i < 2; i++) + return Utils.OnMainThread(async () => { - try - { - mediaFile = await Screenshot.CaptureAsync(); - break; - } - catch { } - await Task.Delay(1000); - } - - var png = await mediaFile.OpenReadAsync(ScreenshotFormat.Png); - Assert.True(png.Length > 0); + ScreenshotResult mediaFile = await Screenshot.CaptureAsync(); + var png = await mediaFile.OpenReadAsync(ScreenshotFormat.Png); + Assert.True(png.Length > 0); + }); } [Fact] - public async Task GetJpegScreenshot() + public Task GetJpegScreenshot() { - ScreenshotResult mediaFile = null; - - for (int i = 0; i < 2; i++) + return Utils.OnMainThread(async () => { - try - { - mediaFile = await Screenshot.CaptureAsync(); - break; - } - catch { } - await Task.Delay(1000); - } - - var png = await mediaFile.OpenReadAsync(ScreenshotFormat.Jpeg); - Assert.True(png.Length > 0); + ScreenshotResult mediaFile = await Screenshot.CaptureAsync(); + var png = await mediaFile.OpenReadAsync(ScreenshotFormat.Jpeg); + Assert.True(png.Length > 0); + }); } } } From 2b7a0876371df51dbcc816722631b40c6b1dc371 Mon Sep 17 00:00:00 2001 From: Shane Neuville Date: Wed, 15 Dec 2021 16:19:19 -0600 Subject: [PATCH 3/4] - wait --- src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs b/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs index 2040b86d6c02..fd10d9f50f25 100644 --- a/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs +++ b/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs @@ -13,6 +13,7 @@ public Task GetPngScreenshot() { return Utils.OnMainThread(async () => { + await Task.Delay(500); ScreenshotResult mediaFile = await Screenshot.CaptureAsync(); var png = await mediaFile.OpenReadAsync(ScreenshotFormat.Png); Assert.True(png.Length > 0); @@ -24,6 +25,7 @@ public Task GetJpegScreenshot() { return Utils.OnMainThread(async () => { + await Task.Delay(500); ScreenshotResult mediaFile = await Screenshot.CaptureAsync(); var png = await mediaFile.OpenReadAsync(ScreenshotFormat.Jpeg); Assert.True(png.Length > 0); From 7b14a334efa2ff2e728de93f97caf58d39b4efb3 Mon Sep 17 00:00:00 2001 From: Shane Neuville Date: Wed, 15 Dec 2021 17:07:28 -0600 Subject: [PATCH 4/4] Update Screenshot_Tests.cs --- src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs b/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs index fd10d9f50f25..85523df24661 100644 --- a/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs +++ b/src/Essentials/test/DeviceTests/Tests/Screenshot_Tests.cs @@ -13,7 +13,7 @@ public Task GetPngScreenshot() { return Utils.OnMainThread(async () => { - await Task.Delay(500); + await Task.Delay(100); ScreenshotResult mediaFile = await Screenshot.CaptureAsync(); var png = await mediaFile.OpenReadAsync(ScreenshotFormat.Png); Assert.True(png.Length > 0); @@ -25,7 +25,7 @@ public Task GetJpegScreenshot() { return Utils.OnMainThread(async () => { - await Task.Delay(500); + await Task.Delay(100); ScreenshotResult mediaFile = await Screenshot.CaptureAsync(); var png = await mediaFile.OpenReadAsync(ScreenshotFormat.Jpeg); Assert.True(png.Length > 0);