From d624278d9283eff3b477d276b3a67be3082a8b00 Mon Sep 17 00:00:00 2001 From: Manuel de la Pena Date: Thu, 9 Feb 2023 12:11:19 -0500 Subject: [PATCH 1/3] [CI] Install the android and iOS dotnet version when they are diff to the maui one. This extra conditional command execution allows to install the donet versions needed by the android and iOS runtimes. This will allow us to be able to work around a situation in which there is a mismatch between the SDKs. --- src/DotNet/DotNet.csproj | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/DotNet/DotNet.csproj b/src/DotNet/DotNet.csproj index 73af4f3e7f83..d8c2a91726cb 100644 --- a/src/DotNet/DotNet.csproj +++ b/src/DotNet/DotNet.csproj @@ -11,6 +11,8 @@ dotnet-install.ps1 $(DotNetOutputPath)$(DotNetInstallScriptName) & '$(DotNetInstallScriptPath)' -Version $(MicrosoftDotnetSdkInternalPackageVersion) -InstallDir '$(DotNetDirectory)' -Verbose + & '$(DotNetInstallScriptPath)' -Version $(VersionFromAndroid) -InstallDir '$(DotNetDirectory)' -Verbose -Runtime dotnet + & '$(DotNetInstallScriptPath)' -Version $(VersionFromMacios) -InstallDir '$(DotNetDirectory)' -Verbose -Runtime dotnet $(DotNetInstallCommand) -AzureFeed $(DotNetFeedUrl) $(DotNetInstallCommand) -AzureFeed $(InternalAzureFeed) -FeedCredential $env:DOTNET_TOKEN powershell -ExecutionPolicy ByPass -NoProfile -Command "$(DotNetInstallCommand)" @@ -20,6 +22,8 @@ dotnet-install.sh $(DotNetOutputPath)$(DotNetInstallScriptName) bash '$(DotNetInstallScriptPath)' --version $(MicrosoftDotnetSdkInternalPackageVersion) --install-dir '$(DotNetDirectory)' --verbose + bash '$(DotNetInstallScriptPath)' --version $(VersionFromAndroid) --install-dir '$(DotNetDirectory)' --verbose -Runtime dotnet + bash '$(DotNetInstallScriptPath)' --version $(VersionFromMacios) --install-dir '$(DotNetDirectory)' --verbose -Runtime dotnet $(DotNetInstallCommand) --azure-feed $(InternalAzureFeed) --feed-credential $DOTNET_TOKEN $(DotNetInstallCommand) --azure-feed $(DotNetFeedUrl) @@ -102,6 +106,8 @@ Outputs="$(DotNetDirectory).stamp"> + + + + + + + + + + + From f33536435014893ad2d7fbb99710e6c131105e43 Mon Sep 17 00:00:00 2001 From: Peter Collins Date: Thu, 9 Feb 2023 17:08:37 -0500 Subject: [PATCH 3/3] Fix pwsh install, use MicrosoftNETCoreAppRefPackageVersion --- src/DotNet/DotNet.csproj | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/DotNet/DotNet.csproj b/src/DotNet/DotNet.csproj index 279ad2fc40f9..78fef9755bc5 100644 --- a/src/DotNet/DotNet.csproj +++ b/src/DotNet/DotNet.csproj @@ -11,8 +11,6 @@ dotnet-install.ps1 $(DotNetOutputPath)$(DotNetInstallScriptName) & '$(DotNetInstallScriptPath)' -Version $(MicrosoftDotnetSdkInternalPackageVersion) -InstallDir '$(DotNetDirectory)' -Verbose - & '$(DotNetInstallScriptPath)' -Version $(VersionFromAndroid) -InstallDir '$(DotNetDirectory)' -Verbose -Runtime dotnet - & '$(DotNetInstallScriptPath)' -Version $(VersionFromMacios) -InstallDir '$(DotNetDirectory)' -Verbose -Runtime dotnet $(DotNetInstallCommand) -AzureFeed $(DotNetFeedUrl) $(DotNetInstallCommand) -AzureFeed $(InternalAzureFeed) -FeedCredential $env:DOTNET_TOKEN powershell -ExecutionPolicy ByPass -NoProfile -Command "$(DotNetInstallCommand)" @@ -22,8 +20,6 @@ dotnet-install.sh $(DotNetOutputPath)$(DotNetInstallScriptName) bash '$(DotNetInstallScriptPath)' --version $(MicrosoftDotnetSdkInternalPackageVersion) --install-dir '$(DotNetDirectory)' --verbose - bash '$(DotNetInstallScriptPath)' --version $(VersionFromAndroid) --install-dir '$(DotNetDirectory)' --verbose -Runtime dotnet - bash '$(DotNetInstallScriptPath)' --version $(VersionFromMacios) --install-dir '$(DotNetDirectory)' --verbose -Runtime dotnet $(DotNetInstallCommand) --azure-feed $(InternalAzureFeed) --feed-credential $DOTNET_TOKEN $(DotNetInstallCommand) --azure-feed $(DotNetFeedUrl) @@ -31,6 +27,7 @@ <_ProvisionDependsOn> _DownloadDotNetInstallScript; + _GetExternalDotNetSdkVersions; _InstallDotNet; _AcquireWorkloadManifests; _InstallWorkloadPacks; @@ -101,24 +98,33 @@ /> - + + Query="/Project/PropertyGroup/MicrosoftNETCoreAppRefPackageVersion/text()"> + Query="/Project/PropertyGroup/MicrosoftNETCoreAppRefPackageVersion/text()"> + + & '$(DotNetInstallScriptPath)' -Version $(VersionFromAndroid) -InstallDir '$(DotNetDirectory)' -Verbose -Runtime dotnet + & '$(DotNetInstallScriptPath)' -Version $(VersionFromMacios) -InstallDir '$(DotNetDirectory)' -Verbose -Runtime dotnet + powershell -ExecutionPolicy ByPass -NoProfile -Command "$(DotNetXARuntimeInstallCommand)" + powershell -ExecutionPolicy ByPass -NoProfile -Command "$(DotNetXMRuntimeInstallCommand)" + + + bash '$(DotNetInstallScriptPath)' --version $(VersionFromAndroid) --install-dir '$(DotNetDirectory)' --verbose -Runtime dotnet + bash '$(DotNetInstallScriptPath)' --version $(VersionFromMacios) --install-dir '$(DotNetDirectory)' --verbose -Runtime dotnet +