Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] MAUI Border class will clip StrokeShape #7103

Closed
danielftz opened this issue May 12, 2022 · 4 comments
Closed

[Android] MAUI Border class will clip StrokeShape #7103

danielftz opened this issue May 12, 2022 · 4 comments
Assignees
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing platform/android 🤖 s/needs-info Issue needs more info from the author s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working

Comments

@danielftz
Copy link

danielftz commented May 12, 2022

Description

image
The StrokeShape of this Border object is a RoundRectangle object, with a transluscent stroke color, and StrokeThicknessof 5. As you can see from the image, the Border object clips the boundary to the edge of its Content, instead of the edge of its StrokeShape

Steps to Reproduce

new Border
{
    Margin = 1,
    Padding = 1,
    StrokeShape = new RoundRectangle
    {
	    CornerRadius = 50 * DeviceDisplay.MainDisplayInfo.Density,
    },
    
    Stroke =  Color.FromHsva(210, 100, 94, 50),
    StrokeThickness = 5,
    
    Content = new Image
    {
	    Source = "my_icon",
    },
    BackgroundColor = Colors.White,
}.Size(100).Center()

Version with bug

Release Candidate 3 (current)

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

API30

Did you find any workaround?

No response

Relevant log output

No response

@danielftz danielftz added s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working labels May 12, 2022
@Eilon Eilon added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label May 12, 2022
@VincentBu VincentBu added the s/triaged Issue has been reviewed label May 13, 2022
@VincentBu
Copy link

VincentBu commented May 13, 2022

Here is my code:
MainPage.xaml

<Border
                Margin="1"
                Padding="1"
                x:Name="border"
                WidthRequest="100"
                HeightRequest="100"
                StrokeThickness="5"
                BackgroundColor="AliceBlue">
                <Border.StrokeShape>
                    <RoundRectangle x:Name="rr" />
                </Border.StrokeShape>
            </Border>

MainPage.xaml.cs

	public MainPage()
	{
		InitializeComponent();
		rr.CornerRadius = 50 * DeviceDisplay.MainDisplayInfo.Density;
        border.Stroke = Color.FromHsva(210, 100, 94, 50);
    }

is this the expected result?
image

@VincentBu VincentBu added s/verified Verified / Reproducible Issue ready for Engineering Triage and removed s/triaged Issue has been reviewed s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels May 13, 2022
@jsuarezruiz jsuarezruiz self-assigned this May 16, 2022
@jsuarezruiz
Copy link
Contributor

I have been testing on the current main branch. I can't reproduce the issue. This issue must have been fixed by #6851

Screenshot_1652691455

@jsuarezruiz jsuarezruiz added the s/needs-info Issue needs more info from the author label May 16, 2022
@ghost
Copy link

ghost commented May 16, 2022

Hi @danielftz. We have added the "s/needs-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@jsuarezruiz
Copy link
Contributor

I am going to close this issue as it seems to be fixed for the next Release. If the problem persists or you find something related, let me know so I can reopen the issue!

@ghost ghost locked as resolved and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing platform/android 🤖 s/needs-info Issue needs more info from the author s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants