Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Performance of gesture updating #21449

Closed
MartyIX opened this issue Mar 26, 2024 · 1 comment
Closed

[Windows] Performance of gesture updating #21449

MartyIX opened this issue Mar 26, 2024 · 1 comment
Labels
area-gestures Gesture types platform/windows 🪟 s/triaged Issue has been reviewed t/bug Something isn't working t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf)
Milestone

Comments

@MartyIX
Copy link
Contributor

MartyIX commented Mar 26, 2024

Description

Speedscope for my application shows significant amount of time spent in UpdateDragAndDropGestureRecognizers:

image

I'm not exactly sure why. I'm filing this issue mostly to reference it a PR of mine.

Steps to Reproduce

Create a project containing:

<Label Text="Drag me">
    <Label.GestureRecognizers>
        <DragGestureRecognizer CanDrag="True" />
    </Label.GestureRecognizers>
</Label>

and many (say 200) of

<Rectangle Stroke="Red"
   Fill="DarkBlue"
   StrokeThickness="4"
   HeightRequest="200"
   WidthRequest="200">
    <Rectangle.GestureRecognizers>
        <DragGestureRecognizer DragStarting="DragGestureRecognizer_DragStarting" />
    </Rectangle.GestureRecognizers>
</Rectangle>

and start the application. UpdateDragAndDropGestureRecognizers should take non-trivial amount of time.

Link to public reproduction project repository

No response

Version with bug

8.0.10 SR3

Is this a regression from previous behavior?

Not sure, did not test other versions

Last version that worked well

Unknown/Other

Affected platforms

Windows

Affected platform versions

No response

Did you find any workaround?

One workardound is to use less drag&drop recognizers. But obviously it's not always possible.

Relevant log output

No response

@MartyIX MartyIX added t/bug Something isn't working platform/windows 🪟 legacy-area-perf Startup / Runtime performance labels Mar 26, 2024
@Zhanglirong-Winnie Zhanglirong-Winnie added the s/triaged Issue has been reviewed label Apr 2, 2024
@Eilon Eilon added t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf) area-gestures Gesture types and removed legacy-area-perf Startup / Runtime performance labels May 10, 2024
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Jun 10, 2024
@MartyIX MartyIX closed this as completed Jun 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-gestures Gesture types platform/windows 🪟 s/triaged Issue has been reviewed t/bug Something isn't working t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf)
Projects
None yet
Development

No branches or pull requests

4 participants