Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression/8.0.0-preview.4.8333] [WinUI] Incorrect size of first item with Border in CollectionView #18128

Closed
sasharp opened this issue Oct 19, 2023 · 4 comments · Fixed by #18356
Closed

[regression/8.0.0-preview.4.8333] [WinUI] Incorrect size of first item with Border in CollectionView #18128

sasharp opened this issue Oct 19, 2023 · 4 comments · Fixed by #18356
Assignees
@emaf
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView fixed-in-8.0.10 fixed-in-8.0.100-rc.2.9530 Look for this fix in 8.0.100-rc.2.9530 i/regression This issue described a confirmed regression on a currently supported version platform/windows 🪟 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone
.NET 8 SR3

Comments

@sasharp
Copy link

sasharp commented Oct 19, 2023 •
edited by samhouts
Loading

Description

The first item of CollectionView has another width than all elements inside of Border.
<CollectionView.ItemTemplate> <DataTemplate> <Grid Padding="10"> <Border> <VerticalStackLayout BackgroundColor="Aqua">
image

Steps to Reproduce

Navigate to the page.

Link to public reproduction project repository

https://github.com/sasharp/MAUI8Bugs

Version with bug

8.0.0-preview.4.8333

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

8.0.0-preview.3.8149

Affected platforms

Windows

Affected platform versions

No response

Did you find any workaround?

The width will be correct when window is resized.

Relevant log output

No response
@sasharp sasharp added the t/bug Something isn't working label Oct 19, 2023
@samhouts samhouts added the potential-regression This issue described a possible regression on a currently supported version., verification pending label Oct 19, 2023
@samhouts samhouts added this to the .NET 8 GA milestone Oct 19, 2023
@Vroomer
Copy link

Vroomer commented Oct 19, 2023

I can confirm this issue.

@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Oct 20, 2023
@XamlTest
Copy link

Verified this on Visual Studio Enterprise 17.8.0 Preview 4.0(8.0.0-rc.2.9373). Repro on Windows 11 with below Project:
MAUI8Bugs.zip

@samhouts samhouts changed the title [WinUI MAUI8] Incorrect size of first item with Border in CollectionView [regression/8.0.0] [WinUI] Incorrect size of first item with Border in CollectionView Oct 20, 2023
@samhouts samhouts changed the title [regression/8.0.0] [WinUI] Incorrect size of first item with Border in CollectionView [regression/8.0.0-preview.4.8333] [WinUI] Incorrect size of first item with Border in CollectionView Oct 23, 2023
@samhouts
Copy link
Member

Confirmed this regressed in 8.0.0-preview.4.8333. #14532 seems sus.

@samhouts samhouts added i/regression This issue described a confirmed regression on a currently supported version and removed potential-regression This issue described a possible regression on a currently supported version., verification pending labels Oct 23, 2023
@samhouts samhouts modified the milestones: .NET 8 GA, .NET 8 SR1 Oct 23, 2023
@Eilon Eilon added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Oct 25, 2023
@emaf emaf mentioned this issue Oct 25, 2023
Merged
@emaf
Copy link
Contributor

emaf commented Nov 1, 2023

Fixed by #18356

@emaf emaf closed this as completed Nov 1, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in MAUI SDK Ongoing Nov 1, 2023
@emaf emaf modified the milestones: .NET 8 SR1, .NET 8 GA Nov 1, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2023
@samhouts samhouts added fixed-in-8.0.100-rc.2.9530 Look for this fix in 8.0.100-rc.2.9530 platform/windows 🪟 labels Jan 31, 2024
@samhouts samhouts modified the milestones: .NET 8 GA, .NET 8 SR3 Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@emaf emaf

Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView fixed-in-8.0.10 fixed-in-8.0.100-rc.2.9530 Look for this fix in 8.0.100-rc.2.9530 i/regression This issue described a confirmed regression on a currently supported version platform/windows 🪟 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 8 SR3
Development

Successfully merging a pull request may close this issue.

Partially revert "[Windows] Update CollectionView changing ItemsLayout (#14532) dotnet/maui
6 participants
@Eilon @emaf @sasharp @samhouts @Vroomer @XamlTest