Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression/8.0.0] MessagingCenter is now internal in .net 8 #16714

Closed
JohnHDev opened this issue Aug 12, 2023 · 7 comments · Fixed by #16798
Closed

[regression/8.0.0] MessagingCenter is now internal in .net 8 #16714

JohnHDev opened this issue Aug 12, 2023 · 7 comments · Fixed by #16798
Labels
fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 potential-regression This issue described a possible regression on a currently supported version., verification pending s/needs-info Issue needs more info from the author s/not-a-bug This isn't actually a bug, or is working as expected t/bug Something isn't working
Milestone

Comments

@JohnHDev
Copy link

Description

There are a large number of projects that haven't yet migrated to .NET Maui, actions like this make it more difficult to migrate from Xamarin Forms.

I know that supporting existing XF developers isn't your highest priority, but actions like this are ill thought out. Please consider reversing decisions like this.

Steps to Reproduce

Convert a XF app that uses MessagingCenter
You are now forced to refactor code to use a version from the community toolkit (and you can't see the deprecation message as the class is now internal, just says you can't use it due to protection level).

That is a poor decision from MS unless your intention is to:
Make your lives easier at the expense of 1000s of Xamarin Forms developers
Intending to make the adoption of .NET Maui more difficult

Link to public reproduction project repository

Ha, funny

Version with bug

8.0.0-preview.7.8842

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

7.0.92

Affected platforms

iOS, Android, Windows, macOS, Other (Tizen, Linux, etc. not supported by Microsoft directly)

Affected platform versions

No response

Did you find any workaround?

.NET 7 Maui, but that isn't in a great state so we are looking if we can migrate straight to .NET 8.

Relevant log output

No response

@JohnHDev JohnHDev added the t/bug Something isn't working label Aug 12, 2023
@Symbai
Copy link
Contributor

Symbai commented Aug 14, 2023

This must be by design as the samples were updated to use the community toolkit instead which should be your workaround alias solution.

487845d
762e07e

@mattleibow
Copy link
Member

mattleibow commented Aug 15, 2023

This was deprecated in net7

https://learn.microsoft.com/en-us/dotnet/maui/fundamentals/messagingcenter

Screenshot 2023-08-15 at 8 35 35 PM

@jfversluis should we maybe copy this API into the MCT and use the new MVVM stuff?

@mattleibow mattleibow added this to the Backlog milestone Aug 15, 2023
@jfversluis
Copy link
Member

Not sure if I'd want to add that to the .NET MAUI Community Toolkit because it would be very temporary and doesn't do anything except for providing some compat. I understand it's a hassle to also take this on, but if you're converting your apps anyway I think this should definitely be part of it as the perf between our MessagingCenter and the MVVM Toolkit implementation is a HUGE improvement.

If it helps anything I'd be willing to wrap something in a separate library to provide some mitigation here, but I don't think we will be reverting this. Would that help anything?

@jfversluis jfversluis added the s/needs-info Issue needs more info from the author label Aug 15, 2023
@ghost
Copy link

ghost commented Aug 15, 2023

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.

@ghost
Copy link

ghost commented Aug 15, 2023

Hi @JohnHDev. We have added the "s/needs-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@samhouts samhouts added the s/not-a-bug This isn't actually a bug, or is working as expected label Aug 15, 2023
@mattleibow
Copy link
Member

Maybe @PureWeen can wrap it with his shandlers? That is meant to be the compat/bugfixy/temp stuff...

@mattleibow
Copy link
Member

Seems a negative thing to add migration pain, so we maybe can revert for now and re-think in net9.

@samhouts samhouts modified the milestones: Backlog, .NET 8 GA Aug 16, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in MAUI SDK Ongoing Aug 17, 2023
@samhouts samhouts added the migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert label Aug 28, 2023
@samhouts samhouts added the potential-regression This issue described a possible regression on a currently supported version., verification pending label Sep 5, 2023
@samhouts samhouts changed the title MessagingCenter is now internal in .net 8 [regression/8.0.0] MessagingCenter is now internal in .net 8 Sep 18, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 potential-regression This issue described a possible regression on a currently supported version., verification pending s/needs-info Issue needs more info from the author s/not-a-bug This isn't actually a bug, or is working as expected t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants