Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off of the concat text document API proposal #1966

Closed
mjbvz opened this issue Apr 13, 2022 · 3 comments
Closed

Migrate off of the concat text document API proposal #1966

mjbvz opened this issue Apr 13, 2022 · 3 comments

Comments

@mjbvz
Copy link

mjbvz commented Apr 13, 2022

👋 Hi, I work on APIs for VS Code

The VS Code Dot Net Interactive notebooks extension currently has access to the concatTextDocument api proposal. We do not plan to finalize this proposal and instead would like to remove to simplify our code. See microsoft/vscode#146781 for details

From a quick search through this repo, I don't think this extension is using ConcatTextDocument but please confirm this and let me know when we can safely remove Dot Net Interactive from the list of this api's consumers

@jonsequitur
Copy link
Contributor

@brettfo Could you please confirm?

@brettfo
Copy link
Member

brettfo commented Apr 14, 2022

Confirmed, we don't use the concat text document APIs.

@mjbvz you can remove us from the list.

@mjbvz
Copy link
Author

mjbvz commented Apr 14, 2022

Thanks for confirming! Will be removed in the next insiders build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants