Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness issue - add contextual information into nullness mismatches #17409

Open
1 of 7 tasks
T-Gro opened this issue Jul 12, 2024 · 1 comment
Open
1 of 7 tasks

Nullness issue - add contextual information into nullness mismatches #17409

T-Gro opened this issue Jul 12, 2024 · 1 comment
Assignees
Labels
Area-Compiler-Checking Type checking, attributes and all aspects of logic checking Area-Diagnostics mistakes and possible improvements to diagnostics Area-Nullness Issues related to handling of Nullable Reference Types
Milestone

Comments

@T-Gro
Copy link
Member

T-Gro commented Jul 12, 2024

Issue description

As of now, nullness related errors are coming from comparing pairs of types in the constraint solver, and all the nullness warnings come from here.

Which means that context (does it come from generic code, equality check, pattern matching, dereferencing a property via dot-lookup,... and many others) is not kept until the nullness constraint solving.

Which in the end makes the messages not user friendly - the ranges fit, but the messaging does not reflect context and source of the nullness mismatch.

Example:

let getLength (x: string | null) = x.Length

image

Choose one or more from the following categories of impact

  • Unexpected nullness warning (false positive in nullness checking, code uses --checknulls and langversion:preview).
  • Missing nullness warning in a case which can produce nulls (false negative, code uses --checknulls and langversion:preview).
  • Breaking change related to older null constructs in code not using the checknulls switch.
  • Breaking change related to generic code and explicit type constraints (null, not null).
  • Type inference issue (i.e. code worked without type annotations before, and applying the --checknulls enforces type annotations).
  • C#/F# interop issue related to nullness metadata.
  • Other (none of the categories above apply).

Operating System

Windows (Default)

What .NET runtime/SDK kind are you seeing the issue on

.NET SDK (.NET Core, .NET 5+)

.NET Runtime/SDK version

No response

Reproducible code snippet and actual behavior

No response

Possible workarounds

No response

@T-Gro T-Gro added Bug Needs-Triage Area-Nullness Issues related to handling of Nullable Reference Types labels Jul 12, 2024
@T-Gro T-Gro self-assigned this Jul 12, 2024
@github-actions github-actions bot added this to the Backlog milestone Jul 12, 2024
@T-Gro T-Gro removed their assignment Jul 12, 2024
@T-Gro T-Gro added Area-Diagnostics mistakes and possible improvements to diagnostics Area-Compiler-Checking Type checking, attributes and all aspects of logic checking and removed Bug Needs-Triage labels Jul 31, 2024
@T-Gro T-Gro modified the milestones: Backlog, August-2024 Jul 31, 2024
@T-Gro
Copy link
Member Author

T-Gro commented Aug 1, 2024

(Hint: For method calls, this would be coming from CanMemberSigsMatchUpToCheck in the subsumeTypes invocation.
From there the info needs to go to ConstraintSolver to be known at warning time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compiler-Checking Type checking, attributes and all aspects of logic checking Area-Diagnostics mistakes and possible improvements to diagnostics Area-Nullness Issues related to handling of Nullable Reference Types
Projects
Status: New
Development

No branches or pull requests

2 participants