Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace active pattern with structs in the compiler code #16286

Closed
psfinaki opened this issue Nov 15, 2023 · 0 comments · Fixed by #16822
Closed

Replace active pattern with structs in the compiler code #16286

psfinaki opened this issue Nov 15, 2023 · 0 comments · Fixed by #16822
Assignees
@psfinaki
Labels
Theme-Performance
Milestone
May-2024

Comments

@psfinaki
Copy link
Member

psfinaki commented Nov 15, 2023 •
edited
Loading

Part of the upcoming perf effort: should have less allocs and speed things up a bit.

The current best RegEx seems to be this one: (?:let|val)(\s+rec)?\s+\(\|[^|)]+\|_\|\)
@psfinaki psfinaki self-assigned this Nov 15, 2023
@github-actions github-actions bot added this to the Backlog milestone Nov 15, 2023
@psfinaki psfinaki mentioned this issue Nov 15, 2023
Open
@psfinaki psfinaki modified the milestones: Backlog, January-2024 Jan 4, 2024
@psfinaki psfinaki moved this from New to Planned in F# Compiler and Tooling Jan 4, 2024
@psfinaki psfinaki mentioned this issue Jan 22, 2024
Merged
@psfinaki psfinaki modified the milestones: January-2024, February-2024 Feb 1, 2024
@vzarytovskii vzarytovskii modified the milestones: February-2024, March-2024 Mar 4, 2024
@psfinaki psfinaki mentioned this issue Mar 6, 2024
Merged
@psfinaki psfinaki moved this from Planned to In Progress in F# Compiler and Tooling Mar 7, 2024
@psfinaki psfinaki mentioned this issue Mar 20, 2024
Merged
@psfinaki psfinaki modified the milestones: March-2024, April-2024 Apr 4, 2024
@psfinaki psfinaki modified the milestones: April-2024, May-2024 May 2, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psfinaki psfinaki

Labels
Theme-Performance
Projects
F# Compiler and Tooling
Archived in project
Milestone
May-2024
Development

Successfully merging a pull request may close this issue.

More ValueOption in compiler: part 3 (and the last) psfinaki/fsharp
2 participants
@vzarytovskii @psfinaki