Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.ObjectDisposedException : Cannot write to a closed TextWriter in printf in numerous tests #11800

Closed
brettfo opened this issue Jul 8, 2021 · 3 comments
Closed

System.ObjectDisposedException : Cannot write to a closed TextWriter in printf in numerous tests #11800

brettfo opened this issue Jul 8, 2021 · 3 comments
Labels
Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code.

Comments

@brettfo
Copy link
Member

brettfo commented Jul 8, 2021

We've had several signed test runs fail recently with:

System.ObjectDisposedException : Cannot write to a closed TextWriter.

at System.IO.__Error.WriterClosed()
   at System.IO.StringWriter.Write(String value)
   at System.IO.TextWriter.SyncTextWriter.Write(String value)
   at [email protected](FSharpList`1 _args, FSharpFunc`2 initial) in D:\workspace\_work\1\s\src\fsharp\FSharp.Core\printf.fs:line 1266
   at Scripting.log[a](PrintfFormat`4 format) in D:\workspace\_work\1\s\src\scripts\scriptlib.fsx:line 81
   at TestFramework.logConfig(TestConfig cfg) in D:\workspace\_work\1\s\tests\FSharp.Test.Utilities\TestFramework.fs:line 360
   at TestFramework.initializeSuite() in D:\workspace\_work\1\s\tests\FSharp.Test.Utilities\TestFramework.fs:line 413
   at [email protected](Unit unitVar) in D:\workspace\_work\1\s\tests\FSharp.Test.Utilities\TestFramework.fs:line 418
   at System.Lazy`1.CreateValue()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Lazy`1.get_Value()
   at TestFramework.testConfig(String testDir) in D:\workspace\_work\1\s\tests\FSharp.Test.Utilities\TestFramework.fs:line 436
   at SingleTest.singleTestBuildAndRun(String dir, Permutation p) in D:\workspace\_work\1\s\tests\fsharp\single-test.fs:line 375
   at [email protected](String dir, Permutation p) in D:\workspace\_work\1\s\tests\fsharp\tests.fs:line 35
   at FSharp.Tests.Core.GeneratedSignatureTests.innerpoly-GENERATED_SIGNATURE() in D:\workspace\_work\1\s\tests\fsharp\tests.fs:line 3131

There are usually ~500 failures, all with the same stack trace.
@brettfo brettfo added the Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. label Jul 8, 2021
@KevinRansom KevinRansom mentioned this issue Jul 8, 2021
Closed
5 tasks
@KevinRansom KevinRansom reopened this Jul 8, 2021
@KevinRansom KevinRansom reopened this Jul 8, 2021
@KevinRansom
Copy link
Member

@brettfo --- can we close this?

@vzarytovskii
Copy link
Member

vzarytovskii commented Aug 3, 2021 •
edited
Loading

@KevinRansom happened once to me in net6 branch with your fix merged:
https://dev.azure.com/dnceng/public/_build/results?buildId=1268817&view=logs&j=966222a4-f29d-5ec0-88cc-1b798728906e&t=052eabf8-67e2-5f29-745c-00cc34aa0e02

@TIHan TIHan mentioned this issue Aug 4, 2021
Closed
8 tasks
@KevinRansom
Copy link
Member

KevinRansom commented Aug 20, 2021 •
edited
Loading

Fixed by #11917

@KevinRansom KevinRansom mentioned this issue Aug 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettfo @vzarytovskii @KevinRansom