Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

Closed PRs are showing up in the Needs Champion column #5

Closed
jeffhandley opened this issue Mar 14, 2022 · 1 comment · Fixed by #26
Closed

Closed PRs are showing up in the Needs Champion column #5

jeffhandley opened this issue Mar 14, 2022 · 1 comment · Fixed by #26
Labels
bug Something isn't working

Comments

@jeffhandley
Copy link
Member

Here's an example where closing a PR resulted in adding the PR to the project board, and it was added into the Needs Champion column despite already being closed:
dotnet/runtime#62435

There have been other scenarios like this too. The root cause of this behavior is that we're relying on the built-in project board automation and this isn't working completely because:

  1. The Needs Champion column is configured with the To do preset; when a PR is added to the board it lands in this column by default
  2. The Done column is configured with the Done preset; when a PR already on the board is closed, it is moved into that column

However, if a PR is already closed when it's added to the board, it lands in the wrong place. To work around this, we will need to move away from the project board automation presets and instead configure FabricBot to prevent the item landing in the wrong column, or use a scheduled search to move items to the Done column if closed.

@jeffhandley jeffhandley added bug Something isn't working untriaged New issue has not been triaged labels Mar 14, 2022
@jeffhandley
Copy link
Member Author

To fix this, we'll just apply a condition such that PRs won't be added to the project board if they're already closed.

@ghost ghost removed the untriaged New issue has not been triaged label Mar 16, 2022
@ghost ghost added the in-pr label Apr 27, 2022
@ghost ghost removed the in-pr label Apr 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant