Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrations: Add IsSqlServer, etc. to MigrationBuilder #8566

Closed
bricelam opened this issue May 23, 2017 · 6 comments
Closed

Migrations: Add IsSqlServer, etc. to MigrationBuilder #8566

bricelam opened this issue May 23, 2017 · 6 comments
Assignees
@bricelam
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. punted-for-2.0 type-enhancement
Milestone
3.0.0

Comments

@bricelam
Copy link
Contributor

Add the same sugar as #8545
@bricelam bricelam mentioned this issue May 23, 2017
Merged
@ajcvickers ajcvickers added this to the 2.0.0-preview2 milestone May 24, 2017
@bricelam bricelam modified the milestones: 2.0.0, 2.0.0-preview2 May 25, 2017
@bricelam bricelam added the help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. label May 31, 2017
@bricelam bricelam modified the milestones: 2.0.0, Backlog Jun 20, 2017
@ajcvickers ajcvickers added this to the Backlog milestone Jun 21, 2017
@laskoviymishka
Copy link
Contributor

It probably already implemented (see b9cd36d)

@bricelam
Copy link
Contributor Author

@laskoviymishka That was about adding it to DbContext.Database. This issue is about adding the same methods to MigrationBuilder.

@AndriySvyryd AndriySvyryd mentioned this issue Aug 30, 2017
Closed
@bricelam bricelam removed their assignment Oct 12, 2018
@ajcvickers ajcvickers modified the milestones: Backlog, 3.0.0 Jan 30, 2019
@bricelam
Copy link
Contributor Author

Marking as a breaking change because I'd like to remove (or obsolete) Migration.ActiveProvider if possible. (Use MigrationBuilder.ActiveProvider or the new sugar methods instead.)

@bricelam
Copy link
Contributor Author

Never mind. We'd have to make a lot of breaking changes to remove Migration.ActiveProvider. I can live with it the way it is.

@bricelam bricelam modified the milestones: 3.0.0, Backlog Mar 20, 2019
@ajcvickers
Copy link
Contributor

@bricelam But we can still add the sugar methods, right? It's just not a breaking change anymore if we don't remove ActiveProvider?

@bricelam
Copy link
Contributor Author

Yeah, I kinda hijacked this issue to try and get a breaking change into 3.0. It didn't work out. This issue can just go back to the backlog as up-for-grabs. The original request isn't breaking (or urgent).

@divega divega added good first issue This issue should be relatively straightforward to fix. help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. and removed help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. good first issue This issue should be relatively straightforward to fix. labels May 31, 2019
@bricelam bricelam added the good first issue This issue should be relatively straightforward to fix. label May 31, 2019
@xaviergxf xaviergxf mentioned this issue Aug 5, 2019
Merged
@ajcvickers ajcvickers removed the help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. label Aug 5, 2019
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 3.0.0 Aug 20, 2019
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 20, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. punted-for-2.0 type-enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
5 participants
@bricelam @divega @ajcvickers @laskoviymishka @AndriySvyryd