Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port long member remarks #9577

Merged
merged 10 commits into from
Feb 1, 2024
Merged

Port long member remarks #9577

merged 10 commits into from
Feb 1, 2024

Conversation

gewarren
Copy link
Contributor

Contributes to dotnet/docs#37859

@ghost ghost assigned gewarren Jan 29, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Jan 29, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

Learn Build status updates of commit 5378b3f:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Globalization/CultureAndRegionInfoBuilder.xml ⚠️Warning View Details
xml/System.Globalization/CultureInfo.xml ⚠️Warning View Details
includes/provider-string-format.md ✅Succeeded n/a (file deleted or renamed)
includes/remarks/System.Threading/WaitHandle/exit-context.md ✅Succeeded View
includes/remarks/System/String/provider-string-format.md ✅Succeeded View
includes/remarks/System/String/simple-string-format.md ✅Succeeded View
includes/simple-string-format.md ✅Succeeded n/a (file deleted or renamed)
snippets/cpp/VS_Snippets_CLR_System/system.string.ctor/cpp/sbyte_ctor1.cpp ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/CurrentCulture/aspculture13.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/CurrentCulture/Async1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/CurrentCulture/changeculture11.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/CurrentCulture/Get1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/CurrentCulture/specific12.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/CurrentUICulture/Async1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/CurrentUICulture/currentuiculture1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/CurrentUICulture/Get1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/InvariantCulture/persist1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Resources/MissingManifestResourceException/Overview/showdate.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Resources/MissingManifestResourceException/Overview/showdate2.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Resources/ResourceManager/.ctor/ctor1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Resources/ResourceManager/.ctor/example.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Resources/ResourceManager/.ctor/greet.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Resources/ResourceManager/GetObject/createresources.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Resources/ResourceManager/GetObject/numberinfo.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Resources/ResourceManager/GetObject/shownumbers.cs ✅Succeeded n/a (file deleted or renamed)

This comment lists only the first 25 files in the pull request.

xml/System.Globalization/CultureAndRegionInfoBuilder.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Globalization/CultureInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interop looks good.

@gewarren gewarren merged commit 6481f01 into dotnet:main Feb 1, 2024
2 of 3 checks passed
@gewarren gewarren deleted the port-more-remarks branch February 1, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants