Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Options classes details #44212

Merged
merged 22 commits into from
Jan 20, 2025
Merged

[QUIC] Options classes details #44212

merged 22 commits into from
Jan 20, 2025

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Jan 10, 2025

Moving some details from the blogpost into docs.

Alternative to this extra documentation could be putting this info straight into API ref docs. I put this into separate conceptual docs because some of these are not exactly short and I'm aware of changes like dotnet/dotnet-api-docs#9577.
I 100% prefer to have this info in one place so either here or API docs are fine. I just don't want to have part in conceptual docs and the rest in API docs. LMK what you'd prefer.

cc @gewarren @dotnet/ncl


Internal previews

📄 File 🔗 Preview link
docs/fundamentals/networking/quic/quic-options.md QUIC configuration options
docs/fundamentals/toc.yml docs/fundamentals/toc

Internal previews

📄 File 🔗 Preview link
docs/fundamentals/networking/quic/quic-options.md QUIC configuration options
docs/fundamentals/toc.yml docs/fundamentals/toc

@ManickaP ManickaP marked this pull request as ready for review January 17, 2025 11:50
@ManickaP ManickaP requested a review from a team as a code owner January 17, 2025 11:50
@gewarren
Copy link
Contributor

@ManickaP I like it where you've put it in the conceptual docs. We should add links from the API docs though.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also committed some changes directly since it was much easier than leaving comments. Feel free to revert if you don't like it.

@ManickaP ManickaP merged commit 4da0d8d into dotnet:main Jan 20, 2025
8 checks passed
@ManickaP ManickaP deleted the quic-options branch January 20, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants