-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for ICorProfilerInfo13 methods and enumeration. #30131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few grammar improvements. Also, should the enumeration be added to profiling-enumerations.md?
docs/framework/unmanaged-api/profiling/cor-prf-handle-type-enumeration.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-getobjectidfromhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-interface.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-interface.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-interface.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-interface.md
Outdated
Show resolved
Hide resolved
…meration.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…royhandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…royhandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…bjectidfromhandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…bjectidfromhandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…bjectidfromhandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…rface.md Co-authored-by: Genevieve Warren <[email protected]>
…rface.md Co-authored-by: Genevieve Warren <[email protected]>
…rface.md Co-authored-by: Genevieve Warren <[email protected]>
…rface.md Co-authored-by: Genevieve Warren <[email protected]>
I would have probably done less errors in french :^)
Good point. I'm udpating it. I also picked a format for the link to .NET 7 content based on .NET 5 one |
The link is correct, but that include file doesn't exist, so you'll need to add it. |
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
@gewarren: why did you close this PR? |
Sorry, not sure what happened. |
I did the same thing by mistake on my own PR so don't be sorry ;^) |
I just added the missing file |
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/cor-prf-handle-type-enumeration.md
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-destroyhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-getobjectidfromhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/profiling-enumerations.md
Outdated
Show resolved
Hide resolved
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Provide the documentation for the new ICorProfilerInfo13 interface implemented by dotnet/runtime#71257
Describe your changes here.
Add the interface, methods and enumeration documentation
Fixes #Issue_Number (if available)