-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document behavior of the newly added System.Text.Json snake case and kebab case policies #36652
Labels
Comments
IEvangelist
added
dotnet-fundamentals/svc
area-System.Text.Json
and removed
Pri3
labels
Aug 11, 2023
github-project-automation
bot
moved this to 🔖 Ready
in dotnet/docs September 2023 sprint
Aug 11, 2023
github-actions
bot
added
📌 seQUESTered
Identifies that an issue has been imported into Quest.
and removed
🗺️ reQUEST
Triggers an issue to be imported into Quest.
labels
Sep 6, 2023
11 tasks
ghost
added
the
in-pr
This issue will be closed (fixed) by an active pull request.
label
Oct 16, 2023
gewarren
moved this from 🏗 In progress
to 👀 In review
in dotnet/docs October 2023 sprint
Oct 17, 2023
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in dotnet/docs October 2023 sprint
Oct 17, 2023
ghost
removed
the
in-pr
This issue will be closed (fixed) by an active pull request.
label
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
.NET 8 includes built-in support for snake_case and kebab-case naming policies. Even though we recently updated the implementation to more closely match the semantics of the equivalent Json.NET feature, we intentionally deviated in certain cases where consensus is that the Json.NET implementation is flawed.
This divergence still has the potential of breaking users that are migrating from Json.NET to System.Text.Json, so we should try to document it. A good starting point is this commit whose test diffs highlight where exactly different outputs should be expected.
In addition to the above, we should consider documenting the fact that the naming policies (both old and new) don't support letters that are surrogate pairs. See dotnet/runtime#90352 for more details.
cc @gewarren @IEvangelist
Associated WorkItem - 156741
The text was updated successfully, but these errors were encountered: