Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverflowException from check-base-image-updates pipeline #1207

Closed
mthalman opened this issue Feb 22, 2024 · 3 comments · Fixed by #1209
Closed

OverflowException from check-base-image-updates pipeline #1207

mthalman opened this issue Feb 22, 2024 · 3 comments · Fixed by #1209

Comments

@mthalman
Copy link
Member

Runs of the check-base-image-updates pipeline are failing when attempting to create a notification issue in GitHub:

Unhandled exception: System.OverflowException: Value was either too large or too small for an Int32.
   at System.Convert.ThrowInt32OverflowException()
   at System.Convert.ToInt32(Int64 value)
   at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider)
   at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) in /_/Octokit/SimpleJson.cs:line 1437
   at Octokit.Internal.SimpleJsonSerializer.GitHubSerializerStrategy.DeserializeObject(Object value, Type type) in /_/Octokit/Http/SimpleJsonSerializer.cs:line 205
   at Octokit.PocoJsonSerializerStrategy.DeserializeObject(Object value, Type type) in /_/Octokit/SimpleJson.cs:line 1492
   at Octokit.Internal.SimpleJsonSerializer.GitHubSerializerStrategy.DeserializeObject(Object value, Type type) in /_/Octokit/Http/SimpleJsonSerializer.cs:line 205
   at Octokit.SimpleJson.DeserializeObject(String json, Type type, IJsonSerializerStrategy jsonSerializerStrategy) in /_/Octokit/SimpleJson.cs:line 584
   at Octokit.SimpleJson.DeserializeObject[T](String json, IJsonSerializerStrategy jsonSerializerStrategy) in /_/Octokit/SimpleJson.cs:line 596
   at Octokit.Internal.SimpleJsonSerializer.Deserialize[T](String json) in /_/Octokit/Http/SimpleJsonSerializer.cs:line 22
   at Octokit.Internal.JsonHttpPipeline.DeserializeResponse[T](IResponse response) in /_/Octokit/Http/JsonHttpPipeline.cs:line 44
   at Octokit.Connection.Run[T](IRequest request, CancellationToken cancellationToken, Func`2 preprocessResponseBody) in /_/Octokit/Http/Connection.cs:line 696
   at Octokit.ApiConnection.Post[T](Uri uri, Object data, String accepts, String contentType, CancellationToken cancellationToken)
   at Microsoft.DotNet.Git.IssueManager.Clients.GitHubClient.CreateNewIssueAsync(String repositoryUrl, String issueTitle, String issueDescription, String personalAccessToken, Nullable`1 milestone, IEnumerable`1 labels, IEnumerable`1 assignees) in /_/src/Microsoft.DotNet.Git.IssueManager/src/Clients/GitHubClient.cs:line 70
   at Microsoft.DotNet.Git.IssueManager.Helpers.RepositoryHelper.CreateNewIssueAsync(String repositoryUrl, String issueTitle, String issueDescription, String gitHubPersonalAccessToken, Nullable`1 milestone, IEnumerable`1 labels, IEnumerable`1 assignees) in /_/src/Microsoft.DotNet.Git.IssueManager/src/Helpers/RepositoryHelper.cs:line 60
   at Microsoft.DotNet.Git.IssueManager.IssueManager.CreateNewIssueAsync(String repositoryUrl, String issueTitle, String issueDescription, Nullable`1 milestone, IEnumerable`1 labels, IEnumerable`1 assignees) in /_/src/Microsoft.DotNet.Git.IssueManager/src/IssueManager.cs:line 62
   at Microsoft.DotNet.ImageBuilder.NotificationService.PostAsync(String title, String description, IEnumerable`1 labels, String repoUrl, String gitHubAccessToken, Boolean isDryRun, IEnumerable`1 comments) in /image-builder/src/NotificationService.cs:line 39
   at Microsoft.DotNet.ImageBuilder.Commands.QueueBuildCommand.LogAndNotifyResultsAsync(Subscription subscription, IEnumerable`1 pathsToRebuild, Build queuedBuild, Exception exception, IEnumerable`1 inProgressBuilds, IEnumerable`1 recentFailedBuilds) in /image-builder/src/Commands/QueueBuildCommand.cs:line 261
   at Microsoft.DotNet.ImageBuilder.Commands.QueueBuildCommand.QueueBuildForStaleImages(Subscription subscription, IEnumerable`1 pathsToRebuild) in /image-builder/src/Commands/QueueBuildCommand.cs:line 156
   at Microsoft.DotNet.ImageBuilder.Commands.QueueBuildCommand.ExecuteAsync() in /image-builder/src/Commands/QueueBuildCommand.cs:line 55

This is caused by octokit/octokit.net#2889.

@mthalman
Copy link
Member Author

This should be fixed now with dotnet/arcade#14505. Just need to upgrade to a newer version of Microsoft.DotNet.Git.IssueManager.

@lbussell
Copy link
Contributor

This is still blocked because there is not a new version of M.DN.Git.IssueManager published yet. The internal builds are being slowed down by other failures in engineering systems today from what I have heard from dnceng.

@mthalman
Copy link
Member Author

mthalman commented Feb 23, 2024

Another option is to add an explicit reference on octokit to get the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants