We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version
docfx pdf
Describe the bug PDF producer property is not written as expected.
producer
To Reproduce
docfx ()
Expected behavior PDF generator exe name with version information is displayed (e.g. 'docfx (2.76.0)`)
Additional context Currently producer property is set on following line.
docfx/src/Docfx.App/PdfBuilder.cs
Line 273 in 464b947
But AssemblyVersionAttribute is missing on Docfx.App assembly.
AssemblyVersionAttribute
Docfx.App
It might be better to use name of Assembly.GetEntryAssembly().Name as producer name. And use AssemblyFileVersionAttribute version instead.
Assembly.GetEntryAssembly().Name
AssemblyFileVersionAttribute
The text was updated successfully, but these errors were encountered:
Producer
Successfully merging a pull request may close this issue.
Describe the bug
PDF
producer
property is not written as expected.To Reproduce
docfx ()
text is displayed asproducer
.Expected behavior
PDF generator exe name with version information is displayed (e.g. 'docfx (2.76.0)`)
Additional context
Currently
producer
property is set on following line.docfx/src/Docfx.App/PdfBuilder.cs
Line 273 in 464b947
But
AssemblyVersionAttribute
is missing onDocfx.App
assembly.It might be better to use name of
Assembly.GetEntryAssembly().Name
as producer name.And use
AssemblyFileVersionAttribute
version instead.The text was updated successfully, but these errors were encountered: