SqlCommand DeriveParameters should not return database in type name for table valued parameters

[ssa3512]

When using SqlCommandBuilder.DeriveParameters() which calls SqlCommand.DeriveParameters() the type name for the TVP in the derived parameters includes the database name which causes ExecuteNonQuery() to fail with the following exception:

System.Data.SqlClient.SqlException: The incoming tabular data stream (TDS) remote procedure call (RPC) protocol stream is incorrect. Table-valued parameter 1 ("@DataTable"), row 0, column 0: Data type 0xF3 (user-defined table type) has a non-zero length database name specified.  Database name is not allowed with a table-valued parameter, only schema name and type name are valid.

In depth write-up and repro project here: ssa3512/DotNet_GetStoredProcCommand_TVP_Repro

https://github.com/dotnet/corefx/blob/875c9842c94fdf3885a7cd28497d492bdd584543/src/System.Data.SqlClient/src/System/Data/SqlClient/SqlCommand.cs#L2212-L2214

[AfsanehR-zz]

@ssa3512 Thank you for providing a repro, will investigate this issue and get back to you.

[Wraith2]

@ssa3512 did you want to have a second pass at this after our discussion on the first PR I shall I pick it up?

[ssa3512]

@Wraith2 I guess I am not sure what needs to be done to support it in a backward compatible way at this point. Additionally, I was unable to get a stable development environment up and running for corefx where I could run all the unit tests. If you have a fix please you can create a PR.

[Wraith2]

I've almost got this written but something caught my attention in the code you posted, there's no escaping. If you used a type name which required the [ ] because it had a space for example that should generate an invalid name shouldn't it? something like dbo.Type With Space when it should be dbo.[Type With Space].

[ssa3512]

I want to say that the names stored in r[colnames] are escaped before that point. I seem to remember seeing [] around the names when writing the workaround for this issue in my application.