Improve SqlDataRecord test coverage

[saurabh500]

Improve SqlDataRecord test coverage.
cc @RemiBou

[RemiBou]

(dotnet/corefx@master...RemiBou:master)

Added 2 tests, is that what you are expecting ? It seems that the first test (SqlRecordFillTest) is quite big and my tests are testing way less things, what do you prefer ?

[saurabh500]

@RemiBou I think you are on the right track. I prefer smaller tests. They are more focussed and easier to debug

[RemiBou]

@saurabh500 on GetOrdinal, can I change the initialisation of _fieldNameLookup with a Lazy<> ? Or is that out of scope ? Or even not a good idea (it'll make this method thread safe)

[saurabh500]

I would say it is out of scope for now until we figure out that Thread Safety is really needed here. If you find along the way, during your involvement that Thread Safety can be utilized here, I would go for it.

[RemiBou]

Given that GetOrdinal is called on the [] accessor, someone might Parallelize some calls (that would be interesting only on record with a lot of columns), but that's not obvious though

[RemiBou]

dotnet/corefx@master...RemiBou:master

+43 lines covered, is that still on phase with your policy/pratice ?

[saurabh500]

Good stuff @RemiBou You are on point.
I would recommend running the Visual Studio, Code formatter to format your code before you send a PR.