Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api Diff between preview 7 and preview 6 #4977

Merged
merged 1 commit into from
Jul 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions release-notes/5.0/preview/api-diff/preview5/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# .NET 5.0 Preview 6 API Changes
# .NET 5.0 Preview 5 API Changes

The following API changes were made in .NET 5.0 Preview 6:
The following API changes were made in .NET 5.0 Preview 5:

- [.NET](./.Net/5.0-preview6.md)
- [ASP.NET](./Asp.Net/5.0-preview6.md)
- [.NET](./.Net/5.0-preview5.md)
- [ASP.NET](./Asp.Net/5.0-preview5.md)
8 changes: 4 additions & 4 deletions release-notes/5.0/preview/api-diff/preview6/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# .NET 5.0 Preview 5 API Changes
# .NET 5.0 Preview 6 API Changes

The following API changes were made in .NET 5.0 Preview 5:
The following API changes were made in .NET 5.0 Preview 6:

- [.NET](./.Net/5.0-preview5.md)
- [ASP.NET](./Asp.Net/5.0-preview5.md)
- [.NET](./.Net/5.0-preview6.md)
- [ASP.NET](./Asp.Net/5.0-preview6.md)
18 changes: 18 additions & 0 deletions release-notes/5.0/preview/api-diff/preview7/.Net/5.0-preview7.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# API Difference net5.0-preview6 vs net5.0-preview7

API listing follows standard diff formatting. Lines preceded by a '+' are
additions and a '-' indicates removal.

* [System](5.0-preview7_System.md)
* [System.Diagnostics.CodeAnalysis](5.0-preview7_System.Diagnostics.CodeAnalysis.md)
* [System.Formats.Asn1](5.0-preview7_System.Formats.Asn1.md)
* [System.IO](5.0-preview7_System.IO.md)
* [System.Net](5.0-preview7_System.Net.md)
* [System.Runtime.CompilerServices](5.0-preview7_System.Runtime.CompilerServices.md)
* [System.Runtime.InteropServices](5.0-preview7_System.Runtime.InteropServices.md)
* [System.Runtime.Intrinsics](5.0-preview7_System.Runtime.Intrinsics.md)
* [System.Runtime.Intrinsics.Arm](5.0-preview7_System.Runtime.Intrinsics.Arm.md)
* [System.Security.Cryptography.X509Certificates](5.0-preview7_System.Security.Cryptography.X509Certificates.md)
* [System.Text](5.0-preview7_System.Text.md)
* [System.Threading.Tasks](5.0-preview7_System.Threading.Tasks.md)

Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# System.Diagnostics.CodeAnalysis

``` diff
namespace System.Diagnostics.CodeAnalysis {
public enum DynamicallyAccessedMemberTypes {
- DefaultConstructor = 1,

+ PublicParameterlessConstructor = 1,
}
}
```

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# System.IO

``` diff
namespace System.IO {
public class MemoryStream : Stream {
- public override void CopyTo(ReadOnlySpanAction<byte, object> callback, object state, int bufferSize);

- public override Task CopyToAsync(Func<ReadOnlyMemory<byte>, object, CancellationToken, ValueTask> callback, object state, int bufferSize, CancellationToken cancellationToken);

}
public abstract class Stream : MarshalByRefObject, IAsyncDisposable, IDisposable {
- public virtual void CopyTo(ReadOnlySpanAction<byte, object> callback, object state, int bufferSize);

- public virtual Task CopyToAsync(Func<ReadOnlyMemory<byte>, object, CancellationToken, ValueTask> callback, object state, int bufferSize, CancellationToken cancellationToken);

}
public class UnmanagedMemoryStream : Stream {
- public override void CopyTo(ReadOnlySpanAction<byte, object> callback, object state, int bufferSize);

}
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# System.Net

``` diff
namespace System.Net {
public class WebHeaderCollection : NameValueCollection, IEnumerable, ISerializable {
- public new string this[string name] { get; set; }
Copy link
Member

@karelz karelz Jul 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed from ref in PR dotnet/runtime#37949 ... we still inherit it from NameValueCollection

Approved on behalf of @dotnet/ncl


}
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# System.Runtime.CompilerServices

``` diff
namespace System.Runtime.CompilerServices {
+ public static class IsExternalInit
+ public sealed class ModuleInitializerAttribute : Attribute {
+ public ModuleInitializerAttribute();
+ }
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# System.Runtime.InteropServices

``` diff
namespace System.Runtime.InteropServices {
+ public sealed class DynamicInterfaceCastableImplementationAttribute : Attribute {
+ public DynamicInterfaceCastableImplementationAttribute();
+ }
+ public interface IDynamicInterfaceCastable {
+ RuntimeTypeHandle GetInterfaceImplementation(RuntimeTypeHandle interfaceType);
+ bool IsInterfaceImplemented(RuntimeTypeHandle interfaceType, bool throwIfNotImplemented);
+ }
}
```

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# System.Runtime.Intrinsics

``` diff
namespace System.Runtime.Intrinsics {
public static class Vector64 {
+ public static Vector64<Double> CreateScalar(double value);
+ public static Vector64<Int64> CreateScalar(long value);
+ public static Vector64<UInt64> CreateScalar(ulong value);
}
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# System.Security.Cryptography.X509Certificates

``` diff
namespace System.Security.Cryptography.X509Certificates {
public sealed class X509ChainPolicy {
+ public bool DisableCertificateDownloads { get; set; }
}
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# System.Text

``` diff
namespace System.Text {
public sealed class CodePagesEncodingProvider : EncodingProvider {
+ public override IEnumerable<EncodingInfo> GetEncodings();
}
public abstract class Encoding : ICloneable {
+ public static Encoding Latin1 { get; }
}
public sealed class EncodingInfo {
+ public EncodingInfo(EncodingProvider provider, int codePage, string name, string displayName);
}
public abstract class EncodingProvider {
+ public virtual IEnumerable<EncodingInfo> GetEncodings();
}
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# System.Threading.Tasks

``` diff
namespace System.Threading.Tasks {
public class Task : IAsyncResult, IDisposable {
+ public static Task<Task> WhenAny(Task task1, Task task2);
+ public static Task<Task<TResult>> WhenAny<TResult>(Task<TResult> task1, Task<TResult> task2);
}
+ public class TaskCompletionSource {
+ public TaskCompletionSource();
+ public TaskCompletionSource(object state);
+ public TaskCompletionSource(object state, TaskCreationOptions creationOptions);
+ public TaskCompletionSource(TaskCreationOptions creationOptions);
+ public Task Task { get; }
+ public void SetCanceled();
+ public void SetCanceled(CancellationToken cancellationToken);
+ public void SetException(IEnumerable<Exception> exceptions);
+ public void SetException(Exception exception);
+ public void SetResult();
+ public bool TrySetCanceled();
+ public bool TrySetCanceled(CancellationToken cancellationToken);
+ public bool TrySetException(IEnumerable<Exception> exceptions);
+ public bool TrySetException(Exception exception);
+ public bool TrySetResult();
+ }
public readonly struct ValueTask : IEquatable<ValueTask> {
+ public static ValueTask CompletedTask { get; }
+ public static ValueTask FromCanceled(CancellationToken cancellationToken);
+ public static ValueTask<TResult> FromCanceled<TResult>(CancellationToken cancellationToken);
+ public static ValueTask FromException(Exception exception);
+ public static ValueTask<TResult> FromException<TResult>(Exception exception);
+ public static ValueTask<TResult> FromResult<TResult>(TResult result);
}
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
# System

``` diff
namespace System {
public static class Console {
+ public static (int Left, int Top) GetCursorPosition();
}
public static class GC {
+ public static GCMemoryInfo GetGCMemoryInfo(GCKind kind);
}
+ public readonly struct GCGenerationInfo {
+ public long FragmentationAfterBytes { get; }
+ public long FragmentationBeforeBytes { get; }
+ public long SizeAfterBytes { get; }
+ public long SizeBeforeBytes { get; }
+ }
+ public enum GCKind {
+ Any = 0,
+ Background = 3,
+ Ephemeral = 1,
+ FullBlocking = 2,
+ }
public readonly struct GCMemoryInfo {
+ public bool Compacted { get; }
+ public bool Concurrent { get; }
+ public long FinalizationPendingCount { get; }
+ public int Generation { get; }
+ public ReadOnlySpan<GCGenerationInfo> GenerationInfo { get; }
+ public long Index { get; }
+ public ReadOnlySpan<TimeSpan> PauseDurations { get; }
+ public double PauseTimePercentage { get; }
+ public long PinnedObjectsCount { get; }
+ public long PromotedBytes { get; }
+ public long TotalCommittedBytes { get; }
}
+ public readonly struct Half : IComparable, IComparable<Half>, IEquatable<Half>, IFormattable {
+ public static Half Epsilon { get; }
+ public static Half MaxValue { get; }
+ public static Half MinValue { get; }
+ public static Half NaN { get; }
+ public static Half NegativeInfinity { get; }
+ public static Half PositiveInfinity { get; }
+ public int CompareTo(Half other);
+ public int CompareTo(object obj);
+ public bool Equals(Half other);
+ public override bool Equals(object obj);
+ public override int GetHashCode();
+ public static bool IsFinite(Half value);
+ public static bool IsInfinity(Half value);
+ public static bool IsNaN(Half value);
+ public static bool IsNegative(Half value);
+ public static bool IsNegativeInfinity(Half value);
+ public static bool IsNormal(Half value);
+ public static bool IsPositiveInfinity(Half value);
+ public static bool IsSubnormal(Half value);
+ public static bool operator ==(Half left, Half right);
+ public static explicit operator Half (double value);
+ public static explicit operator double (Half value);
+ public static explicit operator float (Half value);
+ public static explicit operator Half (float value);
+ public static bool operator >(Half left, Half right);
+ public static bool operator >=(Half left, Half right);
+ public static bool operator !=(Half left, Half right);
+ public static bool operator <(Half left, Half right);
+ public static bool operator <=(Half left, Half right);
+ public static Half Parse(ReadOnlySpan<char> s, NumberStyles style = NumberStyles.AllowDecimalPoint | NumberStyles.AllowExponent | NumberStyles.AllowLeadingSign | NumberStyles.AllowLeadingWhite | NumberStyles.AllowThousands | NumberStyles.AllowTrailingWhite, IFormatProvider provider = null);
+ public static Half Parse(string s);
+ public static Half Parse(string s, NumberStyles style);
+ public static Half Parse(string s, NumberStyles style = NumberStyles.AllowDecimalPoint | NumberStyles.AllowExponent | NumberStyles.AllowLeadingSign | NumberStyles.AllowLeadingWhite | NumberStyles.AllowThousands | NumberStyles.AllowTrailingWhite, IFormatProvider provider = null);
+ public static Half Parse(string s, IFormatProvider provider);
+ public override string ToString();
+ public string ToString(IFormatProvider provider);
+ public string ToString(string format);
+ public string ToString(string format, IFormatProvider provider);
+ public bool TryFormat(Span<char> destination, out int charsWritten, ReadOnlySpan<char> format = default(ReadOnlySpan<char>), IFormatProvider provider = null);
+ public static bool TryParse(ReadOnlySpan<char> s, NumberStyles style, IFormatProvider provider, out Half result);
+ public static bool TryParse(ReadOnlySpan<char> s, out Half result);
+ public static bool TryParse(string s, NumberStyles style, IFormatProvider provider, out Half result);
+ public static bool TryParse(string s, out Half result);
+ }
public static class Math {
+ public const double Tau = 6.2831853071795862;
}
public static class MathF {
+ public const float Tau = 6.28318548f;
}
public enum StringSplitOptions {
+ TrimEntries = 2,
}
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# API Difference aspnet5.0-preview6 vs aspnet5.0-preview7

API listing follows standard diff formatting. Lines preceded by a '+' are
additions and a '-' indicates removal.

* [Microsoft.AspNetCore.Authentication](5.0-preview7_Microsoft.AspNetCore.Authentication.md)
* [Microsoft.AspNetCore.Mvc](5.0-preview7_Microsoft.AspNetCore.Mvc.md)
* [Microsoft.AspNetCore.Mvc.ApiExplorer](5.0-preview7_Microsoft.AspNetCore.Mvc.ApiExplorer.md)
* [Microsoft.AspNetCore.Mvc.ModelBinding](5.0-preview7_Microsoft.AspNetCore.Mvc.ModelBinding.md)
* [Microsoft.AspNetCore.Mvc.ModelBinding.Validation](5.0-preview7_Microsoft.AspNetCore.Mvc.ModelBinding.Validation.md)
* [Microsoft.AspNetCore.Server.Kestrel.Core](5.0-preview7_Microsoft.AspNetCore.Server.Kestrel.Core.md)
* [Microsoft.Extensions.Localization](5.0-preview7_Microsoft.Extensions.Localization.md)
* [Microsoft.Extensions.Localization.Internal](5.0-preview7_Microsoft.Extensions.Localization.Internal.md)
* [Microsoft.Net.Http.Headers](5.0-preview7_Microsoft.Net.Http.Headers.md)

Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Microsoft.AspNetCore.Authentication

``` diff
namespace Microsoft.AspNetCore.Authentication {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @HaoK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep these changes look good

public class AuthenticateResult {
+ public AuthenticateResult Clone();
}
public class AuthenticationProperties {
+ public AuthenticationProperties Clone();
}
public class AuthenticationTicket {
+ public AuthenticationTicket Clone();
}
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Microsoft.AspNetCore.Mvc.ApiExplorer

``` diff
namespace Microsoft.AspNetCore.Mvc.ApiExplorer {
public class ApiParameterDescription {
+ public BindingInfo BindingInfo { get; set; }
}
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Microsoft.AspNetCore.Mvc.ModelBinding.Validation

``` diff
namespace Microsoft.AspNetCore.Mvc.ModelBinding.Validation {
public class ValidationVisitor {
+ public virtual bool Validate(ModelMetadata metadata, string key, object model, bool alwaysValidateAtTopLevel, object container);
}
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Microsoft.AspNetCore.Mvc.ModelBinding

``` diff
namespace Microsoft.AspNetCore.Mvc.ModelBinding {
public class BindingInfo {
+ public EmptyBodyBehavior EmptyBodyBehavior { get; set; }
}
+ public enum EmptyBodyBehavior {
+ Allow = 1,
+ Default = 0,
+ Disallow = 2,
+ }
public abstract class ObjectModelValidator : IObjectModelValidator {
+ public virtual void Validate(ActionContext actionContext, ValidationStateDictionary validationState, string prefix, object model, ModelMetadata metadata, object container);
}
public class ParameterBinder {
+ public virtual ValueTask<ModelBindingResult> BindModelAsync(ActionContext actionContext, IModelBinder modelBinder, IValueProvider valueProvider, ParameterDescriptor parameter, ModelMetadata metadata, object value, object container);
}
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Microsoft.AspNetCore.Mvc

``` diff
namespace Microsoft.AspNetCore.Mvc {
public class FromBodyAttribute : Attribute, IBindingSourceMetadata {
+ public EmptyBodyBehavior EmptyBodyBehavior { get; set; }
}
}
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Microsoft.AspNetCore.Server.Kestrel.Core

``` diff
namespace Microsoft.AspNetCore.Server.Kestrel.Core {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

public class Http2Limits {
+ public TimeSpan KeepAlivePingInterval { get; set; }
+ public TimeSpan KeepAlivePingTimeout { get; set; }
}
public class KestrelServerOptions {
+ public Func<string, Encoding> RequestHeaderEncodingSelector { get; set; }
}
}
```

Loading