Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC transcoding supports custom HttpRule #48192

Closed
1 task done
JamesNK opened this issue May 11, 2023 · 0 comments · Fixed by #48194
Closed
1 task done

gRPC transcoding supports custom HttpRule #48192

JamesNK opened this issue May 11, 2023 · 0 comments · Fixed by #48194
Labels
area-grpc Includes: GRPC wire-up, templates

Comments

@JamesNK
Copy link
Member

JamesNK commented May 11, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Usually, HttpRule comes from Google.Api.CommonProtos. But an app could choose to generate their own by using code generation with http.proto.

Right now this causes this error:

The stored extension value has a type of 'Google.Api.HttpRule, Contracts, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'. This a different from the requested type of 'Google.Api.HttpRule, Google.Api.CommonProtos, Version=2.5.0.0, Culture=neutral, PublicKeyToken=3ec5ea7f18953e47'.

Describe the solution you'd like

Use the functionality in protocolbuffers/protobuf#9655 to support custom HttpRule types.

Additional context

No response
@JamesNK JamesNK added the area-grpc Includes: GRPC wire-up, templates label May 11, 2023
@JamesNK JamesNK mentioned this issue May 11, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-grpc Includes: GRPC wire-up, templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for custom HttpRule types to gRPC JSON transcoding dotnet/aspnetcore
1 participant
@JamesNK