-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider additional FxCop rules to enable #24055
Comments
I believe @JamesNK proposed the globalization rules about using stringcomparers, Ordinal, etc as a good first step, and a case where we have already had some bugs to fix. |
The other good validation is requiring (The .NET SignalR client doesn't count as it has its own strategy to avoid the need for |
Putting this back to |
Quick note, we should be targeting NetAnalyzers that's part of the .NET SDK: https://docs.microsoft.com/en-us/visualstudio/code-quality/migrate-from-fxcop-analyzers-to-net-analyzers?view=vs-2019 |
* Enable CA1821, CA1825-CA1834 Contributes to #24055
Contributes to dotnet#24055
* Enable CA2007 for all ns2.0 projects Contributes to #24055
* Refactor : Enable CA2249 1. Enables CA2249 Contributes to #24055
Contributes to dotnet#24055
* Enable IDE0060 Contributes to #24055
Contributes to dotnet#24055
Thanks for contacting us. We're moving this issue to the |
Closing as I believe this is either no longer relevant, or has been superseded by 1ES infra |
This is a follow up issue from #9620 which added the infrastructure to enable some basic FxCop rules on the repository.
We want to come up with a list of issues so that we can discuss and decide which ones we want to enable and which ones we don't think add value or are not generally applicable enough to a repository this size.
The approach will be to propose a few rules at a time and introduce them based on general agreement so that we can progressively enable the rules we care about.
The text was updated successfully, but these errors were encountered: