Add feature switch to use our new Razor LSP editor. #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTaylorMullen
force-pushed
the
nimullen/17787
branch
from
d3bc9e5 to
fba87b3
Compare
- Added a new Razor LSP content type to identify our new Razor editor experience. - Given that there are already content type associations for the .cshtml/.razor file paths I had to build a RazorEditorFactory that takes precedence over WTE's editor factories and if our feature flags are `true` to change the content type on created editors. - Added a `README.md` to the LanguageServerClient project to indicate how to use the new Razor LSP editor (no functionality currently). - For a feature flag I took a two pronged approach of allowing environment variables or VS' first class feature flag support. We haven't yet made the changes to Visual Studio necessary to surface our feature flag as a properly settable feature flag. Once that is done our feature flag will be toggable via the `Enable Preview Features` dialog. - Didn't feel there was a ton of value in adding tests for our EditorFactory since it acts on things like environment variables and internal VS feature flag functionalities. dotnet/aspnetcore#17787
NTaylorMullen
force-pushed
the
nimullen/17787
branch
from
fba87b3 to
7462e12
Compare
ryanbrandenburg
approved these changes
Jan 10, 2020
| @@ -0,0 +1,12 @@ | |||
| # Using the Razor LSP Editor | |||
ajaybhargavb
approved these changes
Jan 10, 2020
...Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorLSPContentTypeDefinition.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorEditorFactory.cs
Outdated
Show resolved
Hide resolved
...Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorLSPContentTypeDefinition.cs
Show resolved
Hide resolved
rynowak
reviewed
Jan 13, 2020
...alStudio.LanguageServerClient.Razor/Microsoft.VisualStudio.LanguageServerClient.Razor.csproj
Show resolved
Hide resolved
rynowak
reviewed
Jan 13, 2020
rynowak
reviewed
Jan 13, 2020
src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorEditorFactory.cs
Outdated
Show resolved
Hide resolved
rynowak
reviewed
Jan 13, 2020
src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorEditorFactory.cs
Outdated
Show resolved
Hide resolved
rynowak
reviewed
Jan 13, 2020
src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorEditorFactory.cs
Show resolved
Hide resolved
rynowak
reviewed
Jan 13, 2020
src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorEditorFactory.cs
Show resolved
Hide resolved
rynowak
reviewed
Jan 13, 2020
...Razor/src/Microsoft.VisualStudio.RazorExtension/Microsoft.VisualStudio.RazorExtension.csproj
Show resolved
Hide resolved
rynowak
reviewed
Jan 13, 2020
rynowak
reviewed
Jan 13, 2020
- Included the LanguageServer core dlls as part of the VSIX install. To do this I had to expose the language server's output path via a target and then dynamically include its outputs in the VSIX output. - Given how VSIX's are built I could not privately reference our language server to ensure that it's built when the VSIX is built. To work around this limitation I added a `_BuildLanguageServer` target that calls MSBuild directly on the language server as part of build. - For now I'm dynamically booting the currently built language server that's deployed with the extension. I haven't given a lot of thought to what flavor of OS (x64 vs. x86) the server can run on; or if we need to ensure dotnet.exe is available. - Found that the VS LSP client and the O# language server library that we use don't inter-operate as we'd expect. The server ends up telling the client that it doesn't care about text document change events (we do). I've created a separate PR in O# to fix this: OmniSharp/csharp-language-server-protocol#199 - Add OmniSharp 3rd party library to signing information for VSIX insertions. dotnet/aspnetcore#17789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trueto change the content type on created editors.README.mdto the LanguageServerClient project to indicate how to use the new Razor LSP editor (no functionality currently).Enable Preview Featuresdialog.dotnet/aspnetcore#17787