From 36e7b25fd3a66b1b81613333bdecb35e38b872d6 Mon Sep 17 00:00:00 2001
From: Jonathan Peppers <jonathan.peppers@microsoft.com>
Date: Fri, 8 Sep 2017 14:20:15 -0500
Subject: [PATCH] [create-vsix] fix build ordering for xa-prep-tasks on Windows

Context:
https://devdiv.visualstudio.com/DevDiv/Default/_build/index?buildId=978440&_a=summary

On Windows the following scenario is happening:
- `_CreateDependencies` (and `GetXAVersionInfo`) load xa-prep-tasks.dll
- This locks the assembly (on Windows only)
- the `<ProjectReference>` causes xa-prep-tasks to build, but the output
assembly is locked
- There is also an issue here if xa-prep-tasks is not built yet, as
MSBuild tasks are used from it.

The fix is to add a `DependsOnTargets` for `ResolveAssemblies`, this
builds xa-prep-tasks before using it.
---
 build-tools/create-vsix/create-vsix.targets | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build-tools/create-vsix/create-vsix.targets b/build-tools/create-vsix/create-vsix.targets
index 4c2344a7879..ee8769d88eb 100644
--- a/build-tools/create-vsix/create-vsix.targets
+++ b/build-tools/create-vsix/create-vsix.targets
@@ -99,7 +99,7 @@
       Returns="$(IsExperimental)">
   </Target>
   <Target Name="_CreateDependencies"
-      DependsOnTargets="GetXAVersionInfo"
+      DependsOnTargets="ResolveReferences;GetXAVersionInfo"
       BeforeTargets="Build"
       Inputs="Xamarin.Android.Sdk.pkgdef.in"
       Outputs="Xamarin.Android.Sdk.pkgdef">