From 83eac49f1db71c9eeb13dc98b1c5c60c54bf46fb Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Tue, 27 Sep 2022 09:56:21 -0700 Subject: [PATCH 1/2] Add missing HostNameInCertificate property in NetFx Ref --- .../netfx/ref/Microsoft.Data.SqlClient.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs b/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs index 29cd583c94..6190d5da95 100644 --- a/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs +++ b/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs @@ -1037,6 +1037,10 @@ public SqlConnectionStringBuilder(string connectionString) { } [System.ComponentModel.DisplayNameAttribute("Encrypt")] [System.ComponentModel.RefreshPropertiesAttribute(System.ComponentModel.RefreshProperties.All)] public SqlConnectionEncryptOption Encrypt { get { throw null; } set { } } + /// + [System.ComponentModel.DisplayNameAttribute("Host Name In Certificate")] + [System.ComponentModel.RefreshPropertiesAttribute(System.ComponentModel.RefreshProperties.All)] + public string HostNameInCertificate { get { throw null; } set { } } /// [System.ComponentModel.DisplayNameAttribute("Enlist")] [System.ComponentModel.RefreshPropertiesAttribute(System.ComponentModel.RefreshProperties.All)] From 3446ea759af1131b7dea3d440844417f4529756f Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Mon, 3 Oct 2022 11:36:42 -0700 Subject: [PATCH 2/2] Add a test case --- .../FunctionalTests/SqlConnectionStringBuilderTest.cs | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs b/src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs index 14247ac8a5..3337d4aaa4 100644 --- a/src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs +++ b/src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs @@ -360,6 +360,17 @@ public void SetEncryptOnConnectionBuilderMapsToString() } } + [Fact] + public void AbleToSetHostNameInCertificate() + { + var testhostname = "somedomain.net"; + var builder = new SqlConnectionStringBuilder + { + HostNameInCertificate = testhostname + }; + Assert.Equal(testhostname, builder.HostNameInCertificate); + } + [Fact] public void ConnectionBuilderEncryptBackwardsCompatibility() {