From 4f9fae36ea9499f18376c002cf269883cc048a02 Mon Sep 17 00:00:00 2001
From: David Engel <dengel1012@gmail.com>
Date: Tue, 1 Jun 2021 14:19:50 -0700
Subject: [PATCH] Tweak event counter display info

---
 .../SqlClientEventSource.NetCoreApp.cs        | 26 +++++++++----------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlClientEventSource.NetCoreApp.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlClientEventSource.NetCoreApp.cs
index 1cab291611..c0312ca219 100644
--- a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlClientEventSource.NetCoreApp.cs
+++ b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlClientEventSource.NetCoreApp.cs
@@ -67,14 +67,14 @@ protected override void EventCommandMethodCall(EventCommandEventArgs command)
             _activeHardConnections = _activeHardConnections ??
              new PollingCounter("active-hard-connections", this, () => _activeHardConnectionsCounter)
              {
-                 DisplayName = "Actual active connections are made to servers",
+                 DisplayName = "Actual active connections currently made to servers",
                  DisplayUnits = "count"
              };
 
             _hardConnectsPerSecond = _hardConnectsPerSecond ??
                 new IncrementingPollingCounter("hard-connects", this, () => _hardConnectsCounter)
                 {
-                    DisplayName = "Actual connections are made to servers",
+                    DisplayName = "Actual connection rate to servers",
                     DisplayUnits = "count / sec",
                     DisplayRateTimeScale = TimeSpan.FromSeconds(1)
                 };
@@ -82,7 +82,7 @@ protected override void EventCommandMethodCall(EventCommandEventArgs command)
             _hardDisconnectsPerSecond = _hardDisconnectsPerSecond ??
                 new IncrementingPollingCounter("hard-disconnects", this, () => _hardDisconnectsCounter)
                 {
-                    DisplayName = "Actual disconnections are made to servers",
+                    DisplayName = "Actual disconnection rate from servers",
                     DisplayUnits = "count / sec",
                     DisplayRateTimeScale = TimeSpan.FromSeconds(1)
                 };
@@ -90,14 +90,14 @@ protected override void EventCommandMethodCall(EventCommandEventArgs command)
             _activeSoftConnections = _activeSoftConnections ??
                 new PollingCounter("active-soft-connects", this, () => _activeSoftConnectionsCounter)
                 {
-                    DisplayName = "Active connections got from connection pool",
+                    DisplayName = "Active connections retrieved from the connection pool",
                     DisplayUnits = "count"
                 };
 
             _softConnects = _softConnects ??
                 new IncrementingPollingCounter("soft-connects", this, () => _softConnectsCounter)
                 {
-                    DisplayName = "Connections got from connection pool",
+                    DisplayName = "Rate of connections retrieved from the connection pool",
                     DisplayUnits = "count / sec",
                     DisplayRateTimeScale = TimeSpan.FromSeconds(1)
                 };
@@ -105,7 +105,7 @@ protected override void EventCommandMethodCall(EventCommandEventArgs command)
             _softDisconnects = _softDisconnects ??
                 new IncrementingPollingCounter("soft-disconnects", this, () => _softDisconnectsCounter)
                 {
-                    DisplayName = "Connections returned to the connection pool",
+                    DisplayName = "Rate of connections returned to the connection pool",
                     DisplayUnits = "count / sec",
                     DisplayRateTimeScale = TimeSpan.FromSeconds(1)
                 };
@@ -113,15 +113,15 @@ protected override void EventCommandMethodCall(EventCommandEventArgs command)
             _numberOfNonPooledConnections = _numberOfNonPooledConnections ??
                 new PollingCounter("number-of-non-pooled-connections", this, () => _nonPooledConnectionsCounter)
                 {
-                    DisplayName = "Number of connections are not using connection pooling",
-                    DisplayUnits = "count / sec"
+                    DisplayName = "Number of connections not using connection pooling",
+                    DisplayUnits = "count"
                 };
 
             _numberOfPooledConnections = _numberOfPooledConnections ??
                 new PollingCounter("number-of-pooled-connections", this, () => _pooledConnectionsCounter)
                 {
-                    DisplayName = "Number of connections are managed by connection pooler",
-                    DisplayUnits = "count / sec"
+                    DisplayName = "Number of connections managed by the connection pool",
+                    DisplayUnits = "count"
                 };
 
             _numberOfActiveConnectionPoolGroups = _numberOfActiveConnectionPoolGroups ??
@@ -162,7 +162,7 @@ protected override void EventCommandMethodCall(EventCommandEventArgs command)
             _numberOfFreeConnections = _numberOfFreeConnections ??
                 new PollingCounter("number-of-free-connections", this, () => _freeConnectionsCounter)
                 {
-                    DisplayName = "Number of free-ready connections",
+                    DisplayName = "Number of ready connections in the connection pool",
                     DisplayUnits = "count"
                 };
 
@@ -241,7 +241,7 @@ internal override void ExitNonPooledConnection()
         }
 
         /// <summary>
-        /// The number of connections that are managed by the connection pooler
+        /// The number of connections that are managed by the connection pool
         /// </summary>
         [NonEvent]
         internal override void EnterPooledConnection()
@@ -250,7 +250,7 @@ internal override void EnterPooledConnection()
         }
 
         /// <summary>
-        /// The number of connections that are managed by the connection pooler
+        /// The number of connections that are managed by the connection pool
         /// </summary>
         [NonEvent]
         internal override void ExitPooledConnection()