System.Collections.Generic.KeyNotFoundException

[pengweiqhca]

https://github.com/dotnet/SqlClient/blob/main/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionPoolGroupProviderInfo.cs#L107

System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary。
    at TValue System.Collections.Generic.Dictionary<TKey, TValue>.get_Item(TKey key)
    at PermissionSet Microsoft.Data.SqlClient.SqlConnectionPoolGroupProviderInfo.CreateFailoverPermission(SqlConnectionString userConnectionOptions, string actualFailoverPartner)
    at void Microsoft.Data.SqlClient.SqlConnectionPoolGroupProviderInfo.FailoverCheck(bool actualUseFailoverPartner, SqlConnectionString userConnectionOptions, string actualFailoverPartner)
    at void Microsoft.Data.SqlClient.SqlInternalConnectionTds.LoginNoFailover(ServerInfo serverInfo, string newPassword, SecureString newSecurePassword, bool redirectedUserInstance, SqlConnectionString connectionOptions, SqlCredential credential, TimeoutTimer timeout)
    at void Microsoft.Data.SqlClient.SqlInternalConnectionTds.OpenLoginEnlist(TimeoutTimer timeout, SqlConnectionString connectionOptions, SqlCredential credential, string newPassword, SecureString newSecurePassword, bool redirectedUserInstance)
    at new Microsoft.Data.SqlClient.SqlInternalConnectionTds(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, SqlCredential credential, object providerInfo, string newPassword, SecureString newSecurePassword, bool redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, ServerCertificateValidationCallback serverCallback, ClientCertificateRetrievalCallback clientCallback, DbConnectionPool pool, string accessToken, SqlClientOriginalNetworkAddressInfo originalNetworkAddressInfo, bool applyTransientFaultHandling)
    at DbConnectionInternal Microsoft.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)
    at DbConnectionInternal Microsoft.Data.ProviderBase.DbConnectionFactory.CreatePooledConnection(DbConnectionPool pool, DbConnection owningObject, DbConnectionOptions options, DbConnectionPoolKey poolKey, DbConnectionOptions userOptions)
    at DbConnectionInternal Microsoft.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptionsuserOptions, DbConnectionInternal oldConnection)
    at DbConnectionInternal Microsoft.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
    at bool Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, uint waitForMultipleObjectsTimeout, bool allowCreate, bool onlyOneCheckConnection, DbConnectionOptions userOptions, out DbConnectionInternal connection)
    at void Microsoft.Data.ProviderBase.DbConnectionPool.WaitForPendingOpen()

[ErikEJ]

What is your connection string?

[pengweiqhca]

What is your connection string?

data source=172.17.12.70;initial catalog=BetaUserConfig_DB;user id=BetaUserConfig_DB_Admin;password=xxxxx;TrustServerCertificate=true;

[lcheunglci]

That looks like a valid connection string, and I tried a similar connection string and it ran through successfully without an issue. However, the code indicated where the exception was thrown shows that FailOverPartner key doesn't exist in the SqlConnectionString, which sounds similar to this #1594 issue where by setting the FailoverPartner to an empty string, it'll will get around this. Otherwise, we could make a check in the userConnectionOptions if it ContainsKey for FailoverPartner first before it checks if the value is null, so it can avoid the key not found exception from being thrown.

[JRahnama]

@pengweiqhca what version of SqlClient are you using?

[pengweiqhca]

@pengweiqhca what version of SqlClient are you using?

4.1.0

[mark-raymond]

I'm also hitting this (or rather a customer of ours is). We are using Microsoft.Data.SqlClient 4.1.0. The connection string is Data Source=XXXXX;Initial Catalog=XXXXX;Integrated Security=True;Pooling=False;Trust Server Certificate=True;Application Name="Red Gate Software - SQL Tools"

[lcheunglci]

@pengweiqhca @mark-raymond could try out the fix in the PR #1614 and see if it resolves your issue. The PR is tagged in the upcoming release, but I don't have the test environment with a server with AG to verify it before it can be merged.

[lcheunglci]

The pipeline generated the nuget package from the PR which you can download from here: https://sqlclientdrivers.visualstudio.com/904996cc-6198-4d39-8540-eca72bdf0b7b/_apis/build/builds/51479/artifacts?artifactName=Artifacts&api-version=7.0&%24format=zip

[DavoudEshtehari]

@pengweiqhca and @mark-raymond could you verify it with the provided NuGet, please?

[mark-raymond]

Ah, the issue was hit by a customer of ours, I don't actually have access to the environment myself to test against.