-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Parameterized Benchmark Constructors #2482
Comments
I don't think that makes much sense. The values are tied together, so why would they have separate columns? If you just want a cleaner display, you can override [Edit] From your notes, it looks like you actually want a way to specify the params combinations, rather than splitting up a param. Is that correct? |
Thanks for the quick reply. The values aren't exactly tied together in that way. It's more that only some combinations of parameters actually make sense, but not the full cartisian product of all parameters. So at the moment I'm forced to use
Yup, more fine grained control over how parameters are combined would also totally work, although I'm not quite sure what that would look like. It might be helpful to give a more realistic example. This isn't exactly what I'm doing, but imagine I had these parameters:
In this case, I'd basically want the following test matrix:
The If you can think of any other way of acheiving this that would also be helpful. |
I've managed to work out something that uses inheritence to accomplish what I need. Essentially I have an abstract base class that contains some shared parameters, the Benchmark method, and the setup and teardown methods, and then I've got multiple concrete classes that extend that base class and specify additional parameters. The parameter values from the concrete subclass are combined with the parameters from the base class, but not with the parameters from other subclasses. What would really be ideal would be a way to specify one source method that provides multiple parameter values, similar to how the |
That's not a bad idea. We currently only support parameter-less constructors. We could add parameter support. |
I'd like to be able to take a parameter that contains multiple values and display it in the summary table spread across multiple columns, rather than having all the values in the same column. For example, take this benchmark:
Rather than having it display like this (the default):
I'd like to have the value of
MyParameter
split accross multiple columns like so:Note:
GlobalSetup
.Any ideas on whether this is something that's possible?
The text was updated successfully, but these errors were encountered: