Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untracked commit is showing wrong number #1021

Open
1 task done
apetryla opened this issue Jun 12, 2023 · 1 comment
Open
1 task done

Untracked commit is showing wrong number #1021

apetryla opened this issue Jun 12, 2023 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@apetryla
Copy link

OpenShift version

Not related to OpenShift

Problem description

Untracked commit is showing wrong number

Steps to reproduce

  1. Create commit and deployment

Current behavior

Untracked commits is '1' instead of '0'

Expected behavior

Untracked commits should be '0'

Code of Conduct

  • I agree to follow Pelorus's Code of Conduct
@apetryla apetryla added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 12, 2023
@mateusoliveira43
Copy link
Collaborator

The problem seems to be in https://github.com/dora-metrics/pelorus/blob/master/charts/pelorus/templates/dashboard-sdp.yaml#L1455 (wrong expression)

looking into https://github.com/dora-metrics/pelorus/blob/master/charts/pelorus/templates/dashboard-sdp.yaml#L1540, maybe changing and to unless, could fix it.

Requirements

  • Fix problem
  • Write test that covers this scenario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants