Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover bouncing left to right (vice versa) on android #2

Open
rhenmark opened this issue Aug 31, 2017 · 18 comments
Open

Popover bouncing left to right (vice versa) on android #2

rhenmark opened this issue Aug 31, 2017 · 18 comments

Comments

@rhenmark
Copy link

How to fix the bouncing of popover on android? Thank you in advance.

@doomsower
Copy link
Owner

Can you provide some code example, so I can see this bouncing? Because I don't see anything wrong with popovers in my app, and the gif looks alright to me too.

@rhenmark
Copy link
Author

rhenmark commented Aug 31, 2017

it is working great on IOS but on android has an issue
<PopoverTouchable onPopoverDisplayed={() => console.log('Popover displayed!')}>





Block User

<TouchableOpacity style={styles.reportBtn} onPress={() =>{this.popupDialog.show()}}>
Report User


@doomsower
Copy link
Owner

This is incomplete code sample (tags are not closed), but I think I get your idea.
You have a popover with a couple of TouchableOpacities inside?

@rhenmark
Copy link
Author

rhenmark commented Aug 31, 2017

here is the link sir https://docs.google.com/document/d/1D36e22cGYYIVpxtGPLYYvzjJ65ntHJZEvyXOcpAqaak/edit?usp=sharing

I can't paste the code here...

@doomsower
Copy link
Owner

OK, I'll look into this.
I'll copy this code here, If you don't mind:

<PopoverTouchable onPopoverDisplayed={() => console.log('Popover displayed!')}>
      <TouchableOpacity style={styles.profileAction_btn}>
          <Icon name='md-flag' style={styles.txtWhite}/>
      </TouchableOpacity>
      <Popover
          placement='left'
        contentStyle={styles.content}
        arrowStyle={styles.arrow}
        backgroundStyle={styles.background}
        visible={false}
      >
          <TouchableOpacity style={styles.reportBtn}>
            <Text style={styles.txtWhite}>Block User</Text>
          </TouchableOpacity>
          <TouchableOpacity style={styles.reportBtn} onPress={() =>{this.popupDialog.show()}}>
            <Text style={styles.txtWhite}>Report User</Text>
          </TouchableOpacity>
  </Popover>
</PopoverTouchable>

@rhenmark
Copy link
Author

rhenmark commented Aug 31, 2017

okay sir . advance thank you

@doomsower
Copy link
Owner

Can you please add a screenshot of open popover and post your styles?
I tried to replicate your example, but it seems the issue is not with touchables, but with positioning/styles...

@rhenmark
Copy link
Author

rhenmark commented Sep 6, 2017

Thanks a lot, the bouncing effect is only shown on emulator but not in real device.

@doomsower
Copy link
Owner

Still, could you please provide a screenshot? Other users have reported similar issues and I am interested in reproducing/fixing it myself.

@rhenmark
Copy link
Author

rhenmark commented Sep 6, 2017

can i get your email sir? I'll share the link of recorded video.

@doomsower
Copy link
Owner

Please mail to [email protected]. Thanks in advance.

@rhenmark
Copy link
Author

rhenmark commented Sep 6, 2017

just check your email sir. Thanks

@doomsower
Copy link
Owner

I spent some more time trying to reproduce this issue and I couldn't make it bounce on emulator.
What is really strange is that if you play this video frame by frame, the popover starts in rotated position. I have absolutely no idea how rotation can leak into popover/content props. Do you have rotation anywhere in your styles related to popover or its touchable?
I'd appreciate it immensely if you provided whole reproduction code, with styles, layout and all...

@lytrunghieu
Copy link

lytrunghieu commented Nov 8, 2017

I'm think maybe cause animation , How can disable animation ? @doomsower

@doomsower
Copy link
Owner

I changed some things and published v0.0.3. However I'm still unable to reproduce this bug.
If someone can provide code that produces this effect I would greatly appreciate it.

@sraka1
Copy link

sraka1 commented Jul 2, 2018

I'm consistently getting this on Android as well. Indeed, the popover is inverted (rotated 180deg) for a split second (couple ms), which produces a weird effect... Will try to create a reproducible example.

@ArturShoba
Copy link

It is reproducible for me too, but only on Galaxy S8+ device

@Pranit-Harekar
Copy link

Reproducible for us too. Although we are not directly using your library, Ant react native library has this library as a dependency. Is there any fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants