Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message when importing file with morph targets #56

Closed
Kupoman opened this issue Nov 21, 2017 · 4 comments
Closed

Error message when importing file with morph targets #56

Kupoman opened this issue Nov 21, 2017 · 4 comments
Labels

Comments

@Kupoman
Copy link

Kupoman commented Nov 21, 2017

I am trying to add support for morph targets in blendergltf. I have generated a file that is passing validation, but I get a message saying "dependencies.accessors[target.POSITION].clone is not a function" when I try to load that file in the viewer. I am not sure if the problem is with the exporting, my version of the validator, or with the viewer.

Here is the file I am trying upload:
simple_shape_key.zip

@donmccurdy
Copy link
Owner

I think it's a bug in the viewer when interleaved buffers and morph targets are combined. I'll see what can be done about fixing that, but in the meantime if you don't interleave the buffers it should bypass this.

(Or, if it's not intentional that this be interleaved, perhaps byteStride is incorrect?)

@Kupoman
Copy link
Author

Kupoman commented Nov 21, 2017

You were right, it was the interleaved morph target data. When I disabled the interleaving, the error went away. The mesh did not display right, but I am pretty sure that is from bad morph target data.

@donmccurdy donmccurdy added the bug label Nov 22, 2017
@donmccurdy
Copy link
Owner

Does this look correct? Having a go at supporting interleaved morph target data (although on the three.js end we have to de-interleave it).

d09f05be-04ac-48d2-9258-8db6f7659f19-99703-00025d0562d1554d

@donmccurdy
Copy link
Owner

Fixed via mrdoob/three.js#12800, will be updated in the viewer after next three.js release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants