diff --git a/enginetest/queries/alter_table_queries.go b/enginetest/queries/alter_table_queries.go index 86595c543e..f9c72153a2 100644 --- a/enginetest/queries/alter_table_queries.go +++ b/enginetest/queries/alter_table_queries.go @@ -45,6 +45,19 @@ var AlterTableScripts = []ScriptTest{ }, }, }, + { + Name: "issue 8917: exec error nested in block doesn't panic", + SetUpScript: []string{ + "CREATE TABLE b(b int primary key)", + "CREATE TABLE a(a int primary key, b int, CONSTRAINT `fk` FOREIGN KEY (b) REFERENCES b (b))", + }, + Assertions: []ScriptTestAssertion{ + { + Query: "alter table a add column c varchar(100), modify column b varchar(100)", + ExpectedErr: sql.ErrForeignKeyTypeChange, + }, + }, + }, { Name: "variety of alter column statements in a single statement", SetUpScript: []string{ diff --git a/sql/rowexec/other.go b/sql/rowexec/other.go index 8c0ccbf628..793caf5016 100644 --- a/sql/rowexec/other.go +++ b/sql/rowexec/other.go @@ -160,6 +160,10 @@ func (b *BaseBuilder) buildBlock(ctx *sql.Context, n *plan.Block, row sql.Row) ( } handleError := func(err error) error { + if n.Pref == nil { + // alter table blocks do not have a proc reference + return err + } scope := n.Pref.InnermostScope for i := len(scope.Handlers) - 1; i >= 0; i-- { if !scope.Handlers[i].Cond.Matches(err) {