Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pager support to sql shell #8905

Merged
merged 3 commits into from
Feb 28, 2025
Merged

add pager support to sql shell #8905

merged 3 commits into from
Feb 28, 2025

Conversation

macneale4
Copy link
Contributor

Adds the \pager [on|off] capability to dolt sql.

Fixes: #8883

Currently no tests. Would require expect, and is probably beyond the investment in time for this feature.

@macneale4 macneale4 force-pushed the macneale4/shell-pager branch from 17ff6c2 to 82f843b Compare February 28, 2025 02:58
@macneale4 macneale4 requested a review from fulghum February 28, 2025 03:02
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
82f843b ok 5937457
version total_tests
82f843b 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
27e95f0 ok 5937457
version total_tests
27e95f0 5937457
correctness_percentage
100.0

@macneale4 macneale4 requested review from nicktobey and removed request for fulghum February 28, 2025 18:12
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0830e3b ok 5937457
version total_tests
0830e3b 5937457
correctness_percentage
100.0

@macneale4 macneale4 merged commit 9ef74e7 into main Feb 28, 2025
21 checks passed
Copy link

github-actions bot commented Mar 1, 2025

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.33
batching batch sql 10000 1 0.08 1.5
batching by line sql 10000 1 0.09 1.33
blob 1 blob 200000 1 0.91 3.82 4.6
blob 2 blobs 200000 1 0.89 4.42 4.79
blob no blob 200000 1 1 2.23 2.58
col type datetime 200000 1 0.83 2.43 2.73
col type varchar 200000 1 0.75 3.16 3.56
config width 2 cols 200000 1 0.91 2.21 2.47
config width 32 cols 200000 1 1.87 2.02 2.75
config width 8 cols 200000 1 0.97 2.4 2.71
pk type float 200000 1 2.16 0.95 1.21
pk type int 200000 1 0.87 2.32 2.62
pk type varchar 200000 1 1.49 1.73 1.87
row count 1.6mm 1600000 1 5.69 2.99 2.9
row count 400k 400000 1 1.52 2.71 2.78
row count 800k 800000 1 2.89 2.9 2.85
secondary index four index 200000 1 3.55 1.44 1.34
secondary index no secondary 200000 1 0.92 2.41 2.82
secondary index one index 200000 1 1.15 2.41 2.51
secondary index two index 200000 1 2.01 1.79 1.87
sorting shuffled 1mm 1000000 0 5.39 2.75 2.63
sorting sorted 1mm 1000000 1 5.27 2.8 2.67

Copy link

github-actions bot commented Mar 1, 2025

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.22
dolt_blame_commit_filter system table 3.01
dolt_commit_ancestors_commit_filter system table 0.63
dolt_commits_commit_filter system table 1.21
dolt_diff_log_join_from_commit system table 2.8
dolt_diff_log_join_to_commit system table 2.73
dolt_diff_table_from_commit_filter system table 1.11
dolt_diff_table_to_commit_filter system table 1.14
dolt_diffs_commit_filter system table 1.03
dolt_history_commit_filter system table 1.25
dolt_log_commit_filter system table 1.05

Copy link

github-actions bot commented Mar 1, 2025

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.15
adds_updates_deletes 60000 60000 60000 4.6
deletes_only 0 60000 0 2.46
updates_only 0 0 60000 3.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add pager support for dolt sql terminal output
3 participants